From: Jonathan Cameron <jic23@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Lucas Stankus" <lucas.p.stankus@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Lothar Rubusch" <l.rubusch@gmail.com>,
"Mircea Caprioru" <mircea.caprioru@analog.com>,
"Alexandru Tachici" <alexandru.tachici@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: dac: ad5770r: fix error return in ad5770r_read_raw()
Date: Sun, 22 Mar 2026 11:47:18 +0000 [thread overview]
Message-ID: <20260322114718.11992040@jic23-huawei> (raw)
In-Reply-To: <20260312112025.57554-2-antoniu.miclaus@analog.com>
On Thu, 12 Mar 2026 13:20:24 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> Return the error code from regmap_bulk_read() instead of 0 so
> that I/O failures are properly propagated.
>
> Fixes: cbbb819837f6 ("iio: dac: ad5770r: Add AD5770R support")
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks
Jonathan
> ---
> drivers/iio/dac/ad5770r.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/ad5770r.c b/drivers/iio/dac/ad5770r.c
> index cd47cb1c685c..6027e8d88b27 100644
> --- a/drivers/iio/dac/ad5770r.c
> +++ b/drivers/iio/dac/ad5770r.c
> @@ -322,7 +322,7 @@ static int ad5770r_read_raw(struct iio_dev *indio_dev,
> chan->address,
> st->transf_buf, 2);
> if (ret)
> - return 0;
> + return ret;
>
> buf16 = get_unaligned_le16(st->transf_buf);
> *val = buf16 >> 2;
prev parent reply other threads:[~2026-03-22 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 11:20 [PATCH] iio: dac: ad5770r: fix error return in ad5770r_read_raw() Antoniu Miclaus
2026-03-22 11:47 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260322114718.11992040@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.tachici@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=l.rubusch@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.p.stankus@gmail.com \
--cc=mircea.caprioru@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox