From: Gabriel Rondon <grondon@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Nuno Sa <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ti-ads8688: use read_avail for available attributes
Date: Tue, 24 Mar 2026 12:19:57 +0000 [thread overview]
Message-ID: <20260324121957.75404-1-grondon@gmail.com> (raw)
In-Reply-To: <acJ4sPoX_UqorDXS@ashevche-desk.local>
On Tue, 24 Mar 2026 13:42:40 +0200, Andy Shevchenko wrote:
> This is fragile code (however it probably won't be exposed IRL)
> if ADS8688_REALBITS == 32 this is UB in accordance with C standard.
>
> Also the trick with -BIT(x) is harder to read than simple GENMASK().
Good point. Will rework the expression in v2.
> Do not add trailing comma to a terminator.
Will fix.
> This is actually slightly different style to what is put in the above.
> Ideally should be unified, but probably matter for another change
Agreed, will leave for a separate change.
> Why is 'i' signed?
Will declare as unsigned int in the for loop.
> I would leave this on a single line (it's only 81 characters).
Will do.
Thanks for the review.
Gabriel
next prev parent reply other threads:[~2026-03-24 12:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 21:56 [PATCH] iio: adc: ti-ads8688: use read_avail for available attributes Gabriel Rondon
2026-03-24 11:42 ` Nuno Sá
2026-03-24 12:20 ` Gabriel Rondon
2026-03-24 12:24 ` Nuno Sá
2026-03-24 11:42 ` Andy Shevchenko
2026-03-24 12:19 ` Gabriel Rondon [this message]
2026-03-25 19:42 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324121957.75404-1-grondon@gmail.com \
--to=grondon@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox