From: Erikas Bitovtas <xerikasxx@gmail.com>
To: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Erikas Bitovtas <xerikasxx@gmail.com>
Subject: [PATCH v2 6/6] iio: light: vcnl4000: register an IIO device with a device-managed function
Date: Sun, 05 Apr 2026 19:08:43 +0300 [thread overview]
Message-ID: <20260405-vcnl4000-drop-enum-v2-6-7c8dc98c3974@gmail.com> (raw)
In-Reply-To: <20260405-vcnl4000-drop-enum-v2-0-7c8dc98c3974@gmail.com>
Use a device-managed counterpart of iio_device_register() and remove the
redundant iio_device_unregister() call in driver remove function,
allowing us to remove vcnl4000_remove() function altogether.
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
---
drivers/iio/light/vcnl4000.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
index 556dc9afa82c..0813639b5ac1 100644
--- a/drivers/iio/light/vcnl4000.c
+++ b/drivers/iio/light/vcnl4000.c
@@ -2062,11 +2062,7 @@ static int vcnl4000_probe(struct i2c_client *client)
pm_runtime_set_autosuspend_delay(dev, VCNL4000_SLEEP_DELAY_MS);
pm_runtime_use_autosuspend(dev);
- ret = iio_device_register(indio_dev);
- if (ret < 0)
- return ret;
-
- return 0;
+ return devm_iio_device_register(dev, indio_dev);
}
static const struct of_device_id vcnl_4000_of_match[] = {
@@ -2082,13 +2078,6 @@ static const struct of_device_id vcnl_4000_of_match[] = {
};
MODULE_DEVICE_TABLE(of, vcnl_4000_of_match);
-static void vcnl4000_remove(struct i2c_client *client)
-{
- struct iio_dev *indio_dev = i2c_get_clientdata(client);
-
- iio_device_unregister(indio_dev);
-}
-
static int vcnl4000_runtime_suspend(struct device *dev)
{
struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
@@ -2128,7 +2117,6 @@ static struct i2c_driver vcnl4000_driver = {
},
.probe = vcnl4000_probe,
.id_table = vcnl4000_id,
- .remove = vcnl4000_remove,
};
module_i2c_driver(vcnl4000_driver);
--
2.53.0
prev parent reply other threads:[~2026-04-05 16:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-05 16:08 [PATCH v2 0/6] iio: light: vcnl4000: drop enum ID table and use device-managed register Erikas Bitovtas
2026-04-05 16:08 ` [PATCH v2 1/6] iio: light: vcnl4000: validate device by prod ID instead of table ID Erikas Bitovtas
2026-04-09 9:31 ` Andy Shevchenko
2026-04-05 16:08 ` [PATCH v2 2/6] iio: light: vcnl4000: move device tree entries into one line Erikas Bitovtas
2026-04-09 9:29 ` Andy Shevchenko
2026-04-05 16:08 ` [PATCH v2 3/6] iio: light: vcnl4000: drop enum id table in favor of chip structs Erikas Bitovtas
2026-04-05 16:08 ` [PATCH v2 4/6] iio: light: vcnl4000: move power state function into device-managed action Erikas Bitovtas
2026-04-09 9:34 ` Andy Shevchenko
2026-04-05 16:08 ` [PATCH v2 5/6] iio: light: vcnl4000: make pm_runtime_enable() device-managed Erikas Bitovtas
2026-04-09 9:38 ` Andy Shevchenko
2026-04-05 16:08 ` Erikas Bitovtas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260405-vcnl4000-drop-enum-v2-6-7c8dc98c3974@gmail.com \
--to=xerikasxx@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox