[PATCH 0/7] iio: dac: Convert several drivers to devm_mutex_init()

[PATCH 0/7] iio: dac: Convert several drivers to devm_mutex_init()

[David Carlier]

This series converts seven iio DAC/ADDAC drivers to use devm_mutex_init()
instead of mutex_init(). These drivers currently call mutex_init() in
probe but have no .remove() callback, so mutex_destroy() is never called
on device unbind.

Same pattern already accepted in iio for other drivers (e.g. ad5446,
ltc2688, ad7124, ad7606, vcnl4000, etc.).

David Carlier (7):
  iio: dac: ad3552r: Use devm_mutex_init()
  iio: dac: ad7303: Use devm_mutex_init()
  iio: dac: ad5758: Use devm_mutex_init()
  iio: dac: ad5755: Use devm_mutex_init()
  iio: dac: ad5686: Use devm_mutex_init()
  iio: dac: ltc2664: Use devm_mutex_init()
  iio: addac: ad74115: Use devm_mutex_init()

 drivers/iio/addac/ad74115.c | 5 ++++-
 drivers/iio/dac/ad3552r.c   | 4 +++-
 drivers/iio/dac/ad5686.c    | 4 +++-
 drivers/iio/dac/ad5755.c    | 5 +++--
 drivers/iio/dac/ad5758.c    | 4 +++-
 drivers/iio/dac/ad7303.c    | 4 +++-
 drivers/iio/dac/ltc2664.c   | 4 +++-
 7 files changed, 22 insertions(+), 8 deletions(-)

-- 
2.53.0

[PATCH 1/7] iio: dac: ad3552r: Use devm_mutex_init()

[David Carlier]

Use devm_mutex_init() which is helpful with CONFIG_DEBUG_MUTEXES.

Signed-off-by: David Carlier <devnexen@gmail.com>
---
 drivers/iio/dac/ad3552r.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/dac/ad3552r.c b/drivers/iio/dac/ad3552r.c
index 93c33bc3e1be..a2713b0c176e 100644
--- a/drivers/iio/dac/ad3552r.c
+++ b/drivers/iio/dac/ad3552r.c
@@ -629,7 +629,9 @@ static int ad3552r_probe(struct spi_device *spi)
 	if (!dac->model_data)
 		return -EINVAL;
 
-	mutex_init(&dac->lock);
+	err = devm_mutex_init(&spi->dev, &dac->lock);
+	if (err)
+		return err;
 
 	err = ad3552r_init(dac);
 	if (err)
-- 
2.53.0

[PATCH 2/7] iio: dac: ad7303: Use devm_mutex_init()

[David Carlier]

Use devm_mutex_init() which is helpful with CONFIG_DEBUG_MUTEXES.

Signed-off-by: David Carlier <devnexen@gmail.com>
---
 drivers/iio/dac/ad7303.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c
index a88cc639047d..1c2960fa9743 100644
--- a/drivers/iio/dac/ad7303.c
+++ b/drivers/iio/dac/ad7303.c
@@ -218,7 +218,9 @@ static int ad7303_probe(struct spi_device *spi)
 
 	st->spi = spi;
 
-	mutex_init(&st->lock);
+	ret = devm_mutex_init(&spi->dev, &st->lock);
+	if (ret)
+		return ret;
 
 	st->vdd_reg = devm_regulator_get(&spi->dev, "Vdd");
 	if (IS_ERR(st->vdd_reg))
-- 
2.53.0

[PATCH 3/7] iio: dac: ad5758: Use devm_mutex_init()

[David Carlier]

Use devm_mutex_init() which is helpful with CONFIG_DEBUG_MUTEXES.

Signed-off-by: David Carlier <devnexen@gmail.com>
---
 drivers/iio/dac/ad5758.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/dac/ad5758.c b/drivers/iio/dac/ad5758.c
index 4ed4fda76ea9..8e6fb46cce4d 100644
--- a/drivers/iio/dac/ad5758.c
+++ b/drivers/iio/dac/ad5758.c
@@ -851,7 +851,9 @@ static int ad5758_probe(struct spi_device *spi)
 
 	st->spi = spi;
 
-	mutex_init(&st->lock);
+	ret = devm_mutex_init(&spi->dev, &st->lock);
+	if (ret)
+		return ret;
 
 	indio_dev->name = spi_get_device_id(spi)->name;
 	indio_dev->info = &ad5758_info;
-- 
2.53.0

[PATCH 4/7] iio: dac: ad5755: Use devm_mutex_init()

[David Carlier]

Use devm_mutex_init() which is helpful with CONFIG_DEBUG_MUTEXES.

Signed-off-by: David Carlier <devnexen@gmail.com>
---
 drivers/iio/dac/ad5755.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
index d0e5f35462b1..cc6d56140d66 100644
--- a/drivers/iio/dac/ad5755.c
+++ b/drivers/iio/dac/ad5755.c
@@ -827,8 +827,9 @@ static int ad5755_probe(struct spi_device *spi)
 	indio_dev->modes = INDIO_DIRECT_MODE;
 	indio_dev->num_channels = AD5755_NUM_CHANNELS;
 
-	mutex_init(&st->lock);
-
+	ret = devm_mutex_init(&spi->dev, &st->lock);
+	if (ret)
+		return ret;
 
 	pdata = ad5755_parse_fw(&spi->dev);
 	if (!pdata) {
-- 
2.53.0

[PATCH 5/7] iio: dac: ad5686: Use devm_mutex_init()

[David Carlier]

Use devm_mutex_init() which is helpful with CONFIG_DEBUG_MUTEXES.

Signed-off-by: David Carlier <devnexen@gmail.com>
---
 drivers/iio/dac/ad5686.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c
index 4b18498aa074..9a384c50929b 100644
--- a/drivers/iio/dac/ad5686.c
+++ b/drivers/iio/dac/ad5686.c
@@ -494,7 +494,9 @@ int ad5686_probe(struct device *dev,
 	indio_dev->channels = st->chip_info->channels;
 	indio_dev->num_channels = st->chip_info->num_channels;
 
-	mutex_init(&st->lock);
+	ret = devm_mutex_init(dev, &st->lock);
+	if (ret)
+		return ret;
 
 	switch (st->chip_info->regmap_type) {
 	case AD5310_REGMAP:
-- 
2.53.0

[PATCH 6/7] iio: dac: ltc2664: Use devm_mutex_init()

[David Carlier]

Use devm_mutex_init() which is helpful with CONFIG_DEBUG_MUTEXES.

Signed-off-by: David Carlier <devnexen@gmail.com>
---
 drivers/iio/dac/ltc2664.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/dac/ltc2664.c b/drivers/iio/dac/ltc2664.c
index 67f14046cf77..616806615d3d 100644
--- a/drivers/iio/dac/ltc2664.c
+++ b/drivers/iio/dac/ltc2664.c
@@ -675,7 +675,9 @@ static int ltc2664_probe(struct spi_device *spi)
 
 	st->chip_info = chip_info;
 
-	mutex_init(&st->lock);
+	ret = devm_mutex_init(dev, &st->lock);
+	if (ret)
+		return ret;
 
 	st->regmap = devm_regmap_init_spi(spi, &ltc2664_regmap_config);
 	if (IS_ERR(st->regmap))
-- 
2.53.0

[PATCH 7/7] iio: addac: ad74115: Use devm_mutex_init()

[David Carlier]

Use devm_mutex_init() which is helpful with CONFIG_DEBUG_MUTEXES.

Signed-off-by: David Carlier <devnexen@gmail.com>
---
 drivers/iio/addac/ad74115.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/addac/ad74115.c b/drivers/iio/addac/ad74115.c
index f8b04d86b01f..41e0b1d334cc 100644
--- a/drivers/iio/addac/ad74115.c
+++ b/drivers/iio/addac/ad74115.c
@@ -1835,7 +1835,10 @@ static int ad74115_probe(struct spi_device *spi)
 	st = iio_priv(indio_dev);
 
 	st->spi = spi;
-	mutex_init(&st->lock);
+	ret = devm_mutex_init(dev, &st->lock);
+	if (ret)
+		return ret;
+
 	init_completion(&st->adc_data_completion);
 
 	indio_dev->name = AD74115_NAME;
-- 
2.53.0

Re: [PATCH 0/7] iio: dac: Convert several drivers to devm_mutex_init()

[David Lechner]

On 4/10/26 2:37 PM, David Carlier wrote:
> 
> This series converts seven iio DAC/ADDAC drivers to use devm_mutex_init()
> instead of mutex_init(). These drivers currently call mutex_init() in
> probe but have no .remove() callback, so mutex_destroy() is never called
> on device unbind.
> 
> Same pattern already accepted in iio for other drivers (e.g. ad5446,
> ltc2688, ad7124, ad7606, vcnl4000, etc.).
> 
> David Carlier (7):
>   iio: dac: ad3552r: Use devm_mutex_init()
>   iio: dac: ad7303: Use devm_mutex_init()
>   iio: dac: ad5758: Use devm_mutex_init()
>   iio: dac: ad5755: Use devm_mutex_init()
>   iio: dac: ad5686: Use devm_mutex_init()
>   iio: dac: ltc2664: Use devm_mutex_init()
>   iio: addac: ad74115: Use devm_mutex_init()
> 

Jonathan has mentioned before that he doesn't care to take patches like this
unless we are making other cleanups to the driver too. So we'll see what he
says this time.