Re: [PATCH v2 2/4] dt-bindings: iio: magnetometer: Add binding for QST QMC5883P

Krzysztof Kozlowski
2026-04-10T08:06:17Z

On Fri, Apr 10, 2026 at 09:55:24AM +0200, Krzysztof Kozlowski wrote:
> On Thu, Apr 09, 2026 at 09:07:29PM +0000, Hardik Phalet wrote:
> > Add the device tree binding document for the QST QMC5883P, a 3-axis
> > anisotropic magneto-resistive (AMR) sensor with a 16-bit ADC that
> > communicates over I2C. The binding exposes the required 'compatible'
> > and 'reg' properties along with an optional 'vdd-supply' for the
> > 2.5 V–3.6 V VDD rail.
>
> Drop last sentence. We can read the diff.
>
> ...
>
> > +properties:
> > + compatible:
> > + const: qst,qmc5883p
> > +
> > + reg:
> > + maxItems: 1
> > + description: I2C address of the device; the default address is 0x2c.
> > +
> > + vdd-supply:
> > + description:
> > + VDD power supply (2.5 V to 3.6 V). Powers all internal analog and
> > + digital functional blocks.
>
> Supply should be required. Devices need them to operate.

Ah, and since I expect new version, also:

A nit, subject: drop second/last, redundant "binding for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Best regards,
Krzysztof