From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Andrea Merello" <andrea.merello@iit.it>
Subject: Re: [PATCH v3] iio: imu: bno055: add explicit scan buf layout
Date: Sun, 12 Apr 2026 15:24:51 +0100 [thread overview]
Message-ID: <20260412152451.5fbf18a7@jic23-huawei> (raw)
In-Reply-To: <abgZnpVPfKxDURzv@ashevche-desk.local>
On Mon, 16 Mar 2026 16:54:22 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Sat, Mar 14, 2026 at 04:38:25PM -0500, David Lechner wrote:
> > Move the scan buf.chans array into a union along with a struct that
> > gives the layout of the buffer with all channels enabled.
> >
> > Although not technically required in this case, if there had been a
> > different number of items before the quaternion, there could have been
> > a subtle bug with the special alignment needed for the quaternion
> > channel data and the array would have been too small.
>
> This looks good to me,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
Applied to the testing branch of iio.git.
Also +CC Andrea as original author - not sure if email address still
valid however!
prev parent reply other threads:[~2026-04-12 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 21:38 [PATCH v3] iio: imu: bno055: add explicit scan buf layout David Lechner
2026-03-16 14:54 ` Andy Shevchenko
2026-04-12 14:24 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260412152451.5fbf18a7@jic23-huawei \
--to=jic23@kernel.org \
--cc=andrea.merello@iit.it \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox