public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Nikhil Gautam <nikhilgtr@gmail.com>
To: linux-iio@vger.kernel.org
Cc: jic23@kernel.org, dlechner@baylibre.com,
	Nikhil Gautam <nikhilgtr@gmail.com>
Subject: [PATCH v4 0/3] iio: dac: mcp4821: add gain support and fix scale handling
Date: Mon, 13 Apr 2026 15:14:46 +0530	[thread overview]
Message-ID: <20260413094449.18837-1-nikhilgtr@gmail.com> (raw)

This series updates the MCP4821 DAC driver to support configurable gain
and ensures scale handling follows the IIO ABI.

Patch 1 fixes a spelling issue in an enum name.
Patch 2 performs a small refactor to simplify state handling.
Patch 3 adds configurable gain support and corrects scale handling.

The scale is exposed via IIO_CHAN_INFO_SCALE and reflects the selected
gain. The implementation uses IIO_VAL_FRACTIONAL_LOG2 and ensures that
scale_available matches scale. Writes to the scale attribute are validated
and only supported values are accepted.

Changes in v4:
- Split changes into separate patches as suggested
- Fix scale handling to comply with IIO ABI
- Ensure scale_available matches scale
- Handle sysfs write inputs correctly
- Reject invalid scale values

Changes in v3:
- Restore NULL check in indio_dev allocation

Changes in v2:
- Use IIO_CHAN_INFO_SCALE instead of CALIBSCALE
- Fix error handling and cleanup

Nikhil Gautam (3):
  iio: dac: mcp4821: fix spelling mistake in enum name
  iio: dac: mcp4821: move state initialization outside switch
  iio: dac: mcp4821: add configurable gain and fix scale handling

 drivers/iio/dac/mcp4821.c | 107 ++++++++++++++++++++++++++++++--------
 1 file changed, 85 insertions(+), 22 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-04-13  9:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13  9:44 Nikhil Gautam [this message]
2026-04-13  9:44 ` [PATCH v4 1/3] iio: dac: mcp4821: fix spelling mistake in enum name Nikhil Gautam
2026-04-13  9:44 ` [PATCH v4 2/3] iio: dac: mcp4821: move state initialization outside switch Nikhil Gautam
2026-04-13 14:33   ` David Lechner
2026-04-13  9:44 ` [PATCH v4 3/3] iio: dac: mcp4821: add configurable gain and fix scale handling Nikhil Gautam
2026-04-13 14:46   ` David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260413094449.18837-1-nikhilgtr@gmail.com \
    --to=nikhilgtr@gmail.com \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox