From: Ariana Lazar <ariana.lazar@microchip.com>
To: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Conor Dooley <conor.dooley@microchip.com>,
<linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Conor Dooley <conor@kernel.org>,
Ariana Lazar <ariana.lazar@microchip.com>
Subject: [PATCH] dt-bindings: iio: dac: mcp47feb02: Fix binding issues
Date: Thu, 16 Apr 2026 16:33:36 +0300 [thread overview]
Message-ID: <20260416-mcp47feb02-fix5-v1-1-9656c2fed6d2@microchip.com> (raw)
Change maxItems value from 8 to 1 for the channel number reg property.
Change example reg value from 0 to 0x60.
Fix a few typos in property descriptions.
Sort the part numbers in the enum list lexicographically.
Fixes: 4ba12d304175 ("dt-bindings: iio: dac: adding support for Microchip MCP47FEB02")
Reported-by: Conor Dooley <conor@kernel.org>
Closes: https://lore.kernel.org/all/20260403-speed-childless-1360de358229@spud/
Reported-by: David Lechner <dlechner@baylibre.com>
Closes: https://lore.kernel.org/all/dd0dbadb-604b-4f12-8674-268b7db096fd@baylibre.com/
Signed-off-by: Ariana Lazar <ariana.lazar@microchip.com>
---
.../bindings/iio/dac/microchip,mcp47feb02.yaml | 57 +++++++++++-----------
1 file changed, 28 insertions(+), 29 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
index d2466aa6bda2106a8b695347a0edf38462294d03..88a1495f2967a3d821ada7e7e9a7fbb466401040 100644
--- a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
@@ -61,29 +61,29 @@ properties:
compatible:
enum:
- microchip,mcp47feb01
- - microchip,mcp47feb11
- - microchip,mcp47feb21
- microchip,mcp47feb02
+ - microchip,mcp47feb04
+ - microchip,mcp47feb08
+ - microchip,mcp47feb11
- microchip,mcp47feb12
+ - microchip,mcp47feb14
+ - microchip,mcp47feb18
+ - microchip,mcp47feb21
- microchip,mcp47feb22
+ - microchip,mcp47feb24
+ - microchip,mcp47feb28
- microchip,mcp47fvb01
- - microchip,mcp47fvb11
- - microchip,mcp47fvb21
- microchip,mcp47fvb02
- - microchip,mcp47fvb12
- - microchip,mcp47fvb22
- microchip,mcp47fvb04
- - microchip,mcp47fvb14
- - microchip,mcp47fvb24
- microchip,mcp47fvb08
+ - microchip,mcp47fvb11
+ - microchip,mcp47fvb12
+ - microchip,mcp47fvb14
- microchip,mcp47fvb18
+ - microchip,mcp47fvb21
+ - microchip,mcp47fvb22
+ - microchip,mcp47fvb24
- microchip,mcp47fvb28
- - microchip,mcp47feb04
- - microchip,mcp47feb14
- - microchip,mcp47feb24
- - microchip,mcp47feb08
- - microchip,mcp47feb18
- - microchip,mcp47feb28
reg:
maxItems: 1
@@ -111,13 +111,13 @@ properties:
- for single-channel device: Vout0;
- for dual-channel device: Vout0, Vout1;
- for quad-channel device: Vout0, Vout2;
- - for octal-channel device: Vout0, Vout2, Vout6, Vout8;
+ - for octal-channel device: Vout0, Vout2, Vout4, Vout6;
vref1-supply:
description: |
Vref1 pin may be used as a voltage reference when this supply is specified.
The internal reference will be taken into account for voltage reference
- beside VDD if this supply does not exist.
+ besides VDD if this supply does not exist.
This supply will be voltage reference for the following outputs:
- for quad-channel device: Vout1, Vout3;
@@ -141,7 +141,7 @@ properties:
description:
Enable buffering of the external Vref/Vref0 pin in cases where the
external reference voltage does not have sufficient current capability in
- order not to drop it’s voltage when connected to the internal resistor
+ order not to drop its voltage when connected to the internal resistor
ladder circuit.
microchip,vref1-buffered:
@@ -149,7 +149,7 @@ properties:
description:
Enable buffering of the external Vref1 pin in cases where the external
reference voltage does not have sufficient current capability in order not
- to drop it’s voltage when connected to the internal resistor ladder
+ to drop its voltage when connected to the internal resistor ladder
circuit.
patternProperties:
@@ -161,8 +161,7 @@ patternProperties:
properties:
reg:
description: The channel number.
- minItems: 1
- maxItems: 8
+ maxItems: 1
label:
description: Unique name to identify which channel this is.
@@ -227,12 +226,12 @@ allOf:
compatible:
contains:
enum:
- - microchip,mcp47fvb04
- - microchip,mcp47fvb14
- - microchip,mcp47fvb24
- microchip,mcp47feb04
- microchip,mcp47feb14
- microchip,mcp47feb24
+ - microchip,mcp47fvb04
+ - microchip,mcp47fvb14
+ - microchip,mcp47fvb24
then:
patternProperties:
"^channel@[0-3]$":
@@ -245,12 +244,12 @@ allOf:
compatible:
contains:
enum:
- - microchip,mcp47fvb08
- - microchip,mcp47fvb18
- - microchip,mcp47fvb28
- microchip,mcp47feb08
- microchip,mcp47feb18
- microchip,mcp47feb28
+ - microchip,mcp47fvb08
+ - microchip,mcp47fvb18
+ - microchip,mcp47fvb28
then:
patternProperties:
"^channel@[0-7]$":
@@ -280,9 +279,9 @@ examples:
#address-cells = <1>;
#size-cells = <0>;
- dac@0 {
+ dac@60 {
compatible = "microchip,mcp47feb02";
- reg = <0>;
+ reg = <0x60>;
vdd-supply = <&vdac_vdd>;
vref-supply = <&vref_reg>;
@@ -297,6 +296,6 @@ examples:
reg = <0x1>;
label = "Adjustable_voltage_ch1";
};
- };
+ };
};
...
---
base-commit: d2a4ec19d2a2e54c23b5180e939994d3da4a6b91
change-id: 20260416-mcp47feb02-fix5-26994c5b428c
Best regards,
--
Ariana Lazar <ariana.lazar@microchip.com>
next reply other threads:[~2026-04-16 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 13:33 Ariana Lazar [this message]
2026-04-16 15:15 ` [PATCH] dt-bindings: iio: dac: mcp47feb02: Fix binding issues Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260416-mcp47feb02-fix5-v1-1-9656c2fed6d2@microchip.com \
--to=ariana.lazar@microchip.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox