From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Junxiao Chang <junxiao.chang@intel.com>, <jic23@kernel.org>,
<dlechner@baylibre.com>, <nuno.sa@analog.com>, <andy@kernel.org>,
<gye976@gmail.com>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <lars@metafoo.de>
Subject: Re: [PATCH v2] iio: buffer: fix warning in requesting threaded irq
Date: Fri, 17 Apr 2026 13:50:44 +0100 [thread overview]
Message-ID: <20260417135044.000037dd@huawei.com> (raw)
In-Reply-To: <aeIZw2gvbZGJEXy9@ashevche-desk.local>
On Fri, 17 Apr 2026 14:30:11 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Sat, Apr 18, 2026 at 04:51:56PM +0800, Junxiao Chang wrote:
> > IRQF_ONESHOT is for threaded IRQ. If there is no threaded IRQ
> > handler, this flag should not be set.
> >
> > This change fixes a warning during booting with kernel v7.0-rc3:
> >
> > WARNING: kernel/irq/manage.c:1502 at __setup_irq+0x1639/0x2510, CPU#3: iio-sensor-prox/974
Please provide details on which driver is in use to hit this corner case.
That may help people identify if the bug applies to what they are seeing
and also provide some background on how urgent this is to get upstream + backported.
Jonathan
>
> > RIP: 0010:__setup_irq+0x1639/0x2510
>
> Unneeded line (it dups the previous one).
>
> > Call Trace:
> > request_threaded_irq+0x2c7/0x490
> > iio_trigger_attach_poll_func+0x353/0x6b0
> > __iio_update_buffers+0x2420/0x2c70
> > enable_store+0x183/0x270
> > dev_attr_store+0x5e/0x90
>
> > sysfs_kf_write+0x1e8/0x290
> > kernfs_fop_write_iter+0x406/0x5f0
> > vfs_write+0x71c/0xea0
>
> These 3 lines are also redundant.
>
> > v2: using ternary and drop temp variable
>
> Changelog should go...
>
> > Fixes: 23f2d735a932 ("iio: Add helper function for initializing triggered buffers")
> > Signed-off-by: Junxiao Chang <junxiao.chang@intel.com>
> > ---
>
> ...here, when it doesn't go to the commit message. One may find this in the
> lore archive.
>
> ...
>
> Code wise now it looks good.
>
prev parent reply other threads:[~2026-04-17 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-18 0:23 [PATCH] iio: buffer: fix warning in requesting threaded irq Junxiao Chang
2026-04-17 7:25 ` Andy Shevchenko
2026-04-17 7:35 ` Andy Shevchenko
2026-04-18 8:51 ` [PATCH v2] " Junxiao Chang
2026-04-17 11:30 ` Andy Shevchenko
2026-04-17 12:50 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260417135044.000037dd@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gye976@gmail.com \
--cc=jic23@kernel.org \
--cc=junxiao.chang@intel.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox