Re: [PATCH] iio: adc: ingenic-adc: use guard(mutex)(&lock) to handle synchronisation

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 17 Apr 2026 11:01:48 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Wed, Apr 15, 2026 at 10:18:11PM -0300, Felipe Ribeiro de Souza wrote:
> > Replace mutex_lock(&lock) and mutex_unlock(&lock) calls with
> > guard(mutex)(&lock) in functions ingenic_adc_set_adcmd,
> > ingenic_adc_set_config, ingenic_adc_enable, ingenic_adc_capture
> > and ingenic_adc_read_chan_info_raw.  
> 
> We refer to the functions as func().
> 
> > This removes the need to call the unlock function, as the lock is
> > automatically released when the function return or the scope exits
> > for any other case.  
> 
> ...
> 
> >  #include <linux/of.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/property.h>
> > +#include <linux/cleanup.h>  
> 
> Preserve ordering.
> 
> ...
> 
> >  	/* We cannot sample the aux channels in parallel. */
> > -	mutex_lock(&adc->aux_lock);
> > +	guard(mutex)(&adc->lock);  
> 
> 	...
> 
> >  	ret = IIO_VAL_INT;
> >  out:
Holding the lock a bit longer might be fine, but please go read the
comments in cleanup.h.   The short version is don't combine use
of guard() with any gotos in the same function.
It's too high risk given different compiler behaviour and the chance of
code getting reorganized in the future

I wonder if anyone would be interested in applying ACQUIRE() and ACQUIRE_ERR()
to clock management.  Might be worth seeing if that is of interest and general
enough as then you could handle the clk_disable() as well.

> > -	mutex_unlock(&adc->aux_lock);
> >  	clk_disable(adc->clk);  
> 
> Not sure about this. At bare minimum you should elaborate on this change in the
> commit message.
> 
> >  	return ret;  
>