Re: [PATCH 3/4] iio: magnetometer: ak8975: change 'u8*' to 'u8 *' in cast

Andy Shevchenko
2026-04-20T17:23:25Z

On Mon, Apr 20, 2026 at 11:08:03AM +0000, Joshua Crofts wrote:
> Change 'u8*' cast to 'u8 *' as the former triggers a checkpatch error.

...

> ret = i2c_smbus_read_i2c_block_data_or_emulated(
> client, def->data_regs[index],
> - sizeof(rval), (u8*)&rval);
> + sizeof(rval), (u8 *)&rval);

Strange no warnings on the open-ended function call on the first line
(trailing "("). That said, I would rather see the result as

ret = i2c_smbus_read_i2c_block_data_or_emulated(client,
def->data_regs[index],
sizeof(rval),
(u8 *)&rval);

--
With Best Regards,
Andy Shevchenko