public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>, stable <stable@kernel.org>
Subject: Re: [PATCH 1/3] iio: pressure: bmp280: fix stack leak in bmp580 trigger handler
Date: Mon, 20 Apr 2026 19:20:37 +0100	[thread overview]
Message-ID: <20260420192037.2ce1a50e@jic23-huawei> (raw)
In-Reply-To: <84e57bae-358b-43f6-9455-ee6c84b576cb@baylibre.com>

On Thu, 9 Apr 2026 10:01:43 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 4/9/26 8:40 AM, Greg Kroah-Hartman wrote:
> > bmp580_trigger_handler() declares its scan buffer on the stack without
> > an initializer and then memcpy()s 3 bytes of 24-bit sensor data into
> > each 4-byte __le32 field.  The high byte of comp_temp and comp_press is
> > left uninitialized, and the channel storagebits is 32, so two bytes of
> > stack are pushed to userspace per scan.
> > 
> > This is a regression from when the buffer lived in the private data, the
> > move to a stack-local struct dropped the implicit zeroing.
> > bme280_trigger_handler() was fixed up to handle this bug, but this
> > driver was not fixed because there was no padding hole, but rather a
> > short-fill issue.
> > 
> > Fix this all by just zero-initializing the structure on the stack.
> >   
> 
> Reviewed-by: David Lechner <dlechner@baylibre.com>

Series applied to the fixes-togreg branch of iio.git.
I'll be rebase on rc1 once available before sending out a pull request
but in the meantime it can get some build coverage

Thanks,

Jonathan

      reply	other threads:[~2026-04-20 18:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-09 13:40 [PATCH 1/3] iio: pressure: bmp280: fix stack leak in bmp580 trigger handler Greg Kroah-Hartman
2026-04-09 13:40 ` [PATCH 2/3] iio: imu: st_lsm6dsx: fix stack leak in tagged FIFO buffer Greg Kroah-Hartman
2026-04-09 15:25   ` David Lechner
2026-04-09 13:40 ` [PATCH 3/3] iio: imu: adis16550: fix stack leak in trigger handler Greg Kroah-Hartman
2026-04-09 15:29   ` David Lechner
2026-04-09 15:01 ` [PATCH 1/3] iio: pressure: bmp280: fix stack leak in bmp580 " David Lechner
2026-04-20 18:20   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260420192037.2ce1a50e@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox