From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] iio: magnetometer: ak8975: modernize polling loops with iopoll() macros
Date: Tue, 21 Apr 2026 11:38:37 +0100 [thread overview]
Message-ID: <20260421113837.782980aa@jic23-huawei> (raw)
In-Reply-To: <20260421100722.1296-5-joshua.crofts1@gmail.com>
On Tue, 21 Apr 2026 10:07:22 +0000
Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> The driver currently uses while loops and msleep() for polling during
> conversion waits.
>
> Replace the custom polling loops with readx_poll_timeout() and
> read_poll_timeout() macros from <linux/iopoll.h>. This reduces
> boilerplate, standardizes timeout handling and improves overall code
> readability, keeping the original timing and error behaviour.
>
> Assisted-by: Gemini:3.1-Pro
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
The rest of this series looks fine to me.
Jonathan
prev parent reply other threads:[~2026-04-21 10:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 10:07 [PATCH v2 0/4] iio: magnetometer: ak8975: modernize and cleanup driver Joshua Crofts
2026-04-21 10:07 ` [PATCH v2 1/4] iio: magnetometer: ak8975: header cleanup Joshua Crofts
2026-04-21 10:35 ` Jonathan Cameron
2026-04-21 10:52 ` Joshua Crofts
2026-04-21 10:07 ` [PATCH v2 2/4] iio: magnetometer: ak8975: replace usleep_range() with fsleep() Joshua Crofts
2026-04-21 10:07 ` [PATCH v2 3/4] iio: magnetometer: ak8975: change 'u8*' to 'u8 *' in cast Joshua Crofts
2026-04-21 10:07 ` [PATCH v2 4/4] iio: magnetometer: ak8975: modernize polling loops with iopoll() macros Joshua Crofts
2026-04-21 10:38 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421113837.782980aa@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox