Re: [PATCH 13/22] iio: dac: ad5686: fix input raw value check

Nuno Sá
2026-04-23T08:13:06Z

On Wed, Apr 22, 2026 at 03:45:47PM +0100, Rodrigo Alencar via B4 Relay wrote:
> From: Rodrigo Alencar <rodrigo.alencar@analog.com>
>
> Use in_range() to fix range check for input raw value, which is off by
> one, i.e., for a 10-bit DAC the max valid value is 1023, but 1 << 10
> equals 1024, which passes the previous check, allowing an out-of-range
> write.
>
> Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
> ---

I'll reply just to this one but it seems to apply to all "fixes"
patches. They look like a real fix so I would expect to see a Fixes tag
(as Andy suggested) and see those commits coming first in the series.

Other than that, code looks good (for those patches)

- Nuno Sá
> drivers/iio/dac/ad5686.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c
> index 19d791c655b7..07a944311f0e 100644
> --- a/drivers/iio/dac/ad5686.c
> +++ b/drivers/iio/dac/ad5686.c
> @@ -185,7 +185,7 @@ static int ad5686_write_raw(struct iio_dev *indio_dev,
>
> switch (mask) {
> case IIO_CHAN_INFO_RAW:
> - if (val > (1 << chan->scan_type.realbits) || val < 0)
> + if (!in_range(val, 0, 1 << chan->scan_type.realbits))
> return -EINVAL;
>
> mutex_lock(&st->lock);
>
> --
> 2.43.0
>
>