Re: [PATCH 03/22] dt-bindings: iio: dac: ad5696: rework on power supplies

Jonathan Cameron
2026-04-23T17:47:35Z

On Wed, 22 Apr 2026 15:45:37 +0100
Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@kernel.org> wrote:

> From: Rodrigo Alencar <rodrigo.alencar@analog.com>
>
> Add supplies for VDD, VLOGIC and VREF input voltage pins. The vcc-supply
> property is deprecated.

Please provide some information on why? Was it always just wrong and that
naming was never used for any of the supported parts?

> Certain devices require vref-supply to be
> available once an internal reference voltage is absent. Still, this patch
> does not add those as 'required' so that the ABI is not broken.
>
> Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
> ---
> .../devicetree/bindings/iio/dac/adi,ad5696.yaml | 21 ++++++++++++++++++---
> 1 file changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> index f286e5072abc..21b80fe597d1 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> @@ -38,9 +38,22 @@ properties:
> reg:
> maxItems: 1
>
> + vdd-supply:
> + description: Input power supply.
> +
> + vlogic-supply:
> + description:
> + Digital power supply. If not supplied, it is assumed to be the same as
> + vdd-supply. VLOGIC may be hardwired to VDD in some board designs or
> + internally connected in small packages.
> +
> + vref-supply:
> + description:
> + Reference voltage supply. If not supplied the internal reference is used.
> +
> vcc-supply:
> - description: |
> - The regulator supply for DAC reference voltage.
> + deprecated: true
> + description: Use vref-supply instead.
>
> reset-gpios:
> description: Active-low RESET pin to reset the device.
> @@ -88,7 +101,9 @@ examples:
> ad5696: dac@0 {
> compatible = "adi,ad5696";
> reg = <0>;
> - vcc-supply = <&dac_vref>;
> + vdd-supply = <&dac_vdd>;
> + vlogic-supply = <&dac_vlogic>;
> + vref-supply = <&dac_vref>;
> ldac-gpios = <&gpio0 1 GPIO_ACTIVE_LOW>;
> };
> };
>