Re: [PATCH v4 1/2] iio: adc: mcp320x: sort headers alphabetically

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 24 Apr 2026 11:01:19 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Thu, Apr 23, 2026 at 05:45:08PM -0300, Gustavo Pagnotta Faria wrote:
> > On Thu, Apr 23, 2026 at 20:46:26 +0300, Andy Shevchenko wrote:  
> > > Is this SoB chain for real? If you want to give credits to mentors or so,
> > > it should be done differently.  
> > 
> > Yes, the chain is real. Eduardo, Christian, and I are classmates at the
> > University of São Paulo (IME-USP), and we are working on this driver
> > together as a group assignment.
> > 
> > We are doing mob programming on the same machine, which is why we
> > included the Co-developed-by tags for everyone involved in the changes.
> > They are not my mentors or professors.  
> 
> A-ha, thanks for elaboration on this. See below how I suggest to address this
> case.
> 
> > However, I understand that having three authors for such a trivial patch
> > (like sorting headers) looks highly unusual. I also realize that, as the
> > sender of the patch, my Signed-off-by should have been placed at the
> > very bottom of the chain.  
> 
> We use terms: Author, Committer, Submitter. The latter one is probably what
> you are referring to.
> 
> > For the upcoming v5, would you prefer me to keep the Co-developed-by
> > tags on the main refactoring patch (Patch 2) and leave only my
> > Signed-off-by on this trivial header sorting one?  
> 
> It's up to maintainers. Just put the information in the cover letter to explain
> these rather long SoB chains. If maintainer is happy, they will take change as
> is, otherwise they will ask for modifications.
I'm fine with a bunch of co-devs for IIO (and had a good idea
what was going on in this case!)

Given I'm getting a lot of patches from IME-USP folk this year
I would encourage you all to do a bit of cross review.  Some of the
patches are tackling similar problems in different drivers, so
it would be helpful perhaps to 'spread' the feedback by pointing
out where similar improvements apply to your fellow students work.

I guess that might well be going on behind the scenes, but feel
free to do it in public too.   A large part of getting involved in
the upstream kernel is in helping to review!

Thanks,

Jonathan
 
>