From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F405306D26; Mon, 27 Apr 2026 11:30:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777289411; cv=none; b=MEmeo7W095cD3b93T2fDcgMmXD+T7bz6MeIzDChp0lCuKxhPKbs6a84bcrLoQJR7mn2z2hlwQRgrk8wIwCO8BHRfI5qqyH37L3u7LLnhbr9+jvYD3oubo8LL6zVqhAjQ6ypqTvqo6zw9WuxwI8fgNctU4ZX7shHIrc0uTxfxjko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777289411; c=relaxed/simple; bh=w0XGwELR3xciDLIHcBkj4Shl2CS+SlLGPOLI5Qn/iG4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PuC6Wvvi+CYt5j5AKp/TIagXce2KLf1C+ASjDlaot8lwkjLs5tOkLp/eitlZ9tLszvWsFkwaiBtHiiETisyGvKcM2m3m3hBQsqKfdhrXhutjN9VquQ/rgxpuetNm+Xgoniosqzyo98H/pdHPeIEth5z2U6A9Yskf5QOLVVzr454= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fCPWyBY0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fCPWyBY0" Received: by smtp.kernel.org (Postfix) with ESMTPS id 0B5CAC2BCB6; Mon, 27 Apr 2026 11:30:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777289411; bh=w0XGwELR3xciDLIHcBkj4Shl2CS+SlLGPOLI5Qn/iG4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=fCPWyBY0v4WdwqFRA533/SfIz0YIb2U4z6w/xtKiwrlhN+kurbocdZhPKT05wVDFO 3OwBQgiNAzUfJMeTCW0SWcLBNtKq1YkTiCu6Sr9Q1vn5GOgiFjfmigPldnx5mZiyye LsJlDZbu7Wjq64NdceaMu7hoM7FsqhAFbAqBPXWbIiqGEtvH/qDy9xsFiVBHdLsdr4 6hpH8uhWHKQTXWwsEW/TDM2Zw/zlARy9uNeE+8ILVt8M8ypWN7szuHwltWxMGD/9E2 ReqI28OO1PAyCtb8auZJBZX84VCpDZALf/HLx2z7cINW1Czb2lOJilRjbzDpnqBDFS tNPYkOtwB6bJg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE6F7FF8861; Mon, 27 Apr 2026 11:30:10 +0000 (UTC) From: Rodrigo Alencar via B4 Relay Date: Mon, 27 Apr 2026 12:30:08 +0100 Subject: [PATCH v2 01/11] iio: dac: ad5686: fix ref bit initialization for single-channel parts Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260427-ad5686-fixes-v2-1-188e05199368@analog.com> References: <20260427-ad5686-fixes-v2-0-188e05199368@analog.com> In-Reply-To: <20260427-ad5686-fixes-v2-0-188e05199368@analog.com> To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Popa , Jonathan Cameron , Greg Kroah-Hartman , Michael Auchter , Jonathan Cameron Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , Andy Shevchenko , Rodrigo Alencar X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777289409; l=1787; i=rodrigo.alencar@analog.com; s=default; h=from:subject:message-id; bh=xzPfTOvqELCSXjM2q6f7n3lj/43Dt23++PuhGryImaI=; b=/VSNs5CjaTaSZrcComveElieZt3qqqjmLcEMRGuWauxKdCNfqeu4zlQjmTuDUrNtn3TmiU1Pw FuQWajvkCCoCMLfD5XvgQmc+gMCEOe6ejh3eUmiR/B6dVR+d2eHM/b2 X-Developer-Key: i=rodrigo.alencar@analog.com; a=ed25519; pk=ULeHbgU/OYh/PG/4anHDfLgldFItQHAhOktYRVLMFRo= X-Endpoint-Received: by B4 Relay for rodrigo.alencar@analog.com/default with auth_id=561 X-Original-From: Rodrigo Alencar Reply-To: rodrigo.alencar@analog.com From: Rodrigo Alencar The reference bit position was ignored when writing the register at the probe() function (!!val was used). When such bit is 1, internal voltage reference is disabled so that an external one can be used. For multi-channel devices, bit 0 of the Internal Reference Setup command behaves the same way, so AD5686_REF_BIT_MSK is created. The issue exists since support for single-channel devices were first introduced. Fixes: be1b24d24541 ("iio:dac:ad5686: Add AD5691R/AD5692R/AD5693/AD5693R support") Signed-off-by: Rodrigo Alencar --- drivers/iio/dac/ad5686.c | 6 +++--- drivers/iio/dac/ad5686.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c index 9a384c50929b..3b48ddf8dd3c 100644 --- a/drivers/iio/dac/ad5686.c +++ b/drivers/iio/dac/ad5686.c @@ -511,7 +511,7 @@ int ad5686_probe(struct device *dev, break; case AD5686_REGMAP: cmd = AD5686_CMD_INTERNAL_REFER_SETUP; - ref_bit_msk = 0; + ref_bit_msk = AD5686_REF_BIT_MSK; break; case AD5693_REGMAP: cmd = AD5686_CMD_CONTROL_REG; @@ -522,9 +522,9 @@ int ad5686_probe(struct device *dev, return -EINVAL; } - val = (has_external_vref | ref_bit_msk); + val = (has_external_vref) ? ref_bit_msk : 0; - ret = st->write(st, cmd, 0, !!val); + ret = st->write(st, cmd, 0, val); if (ret) return ret; diff --git a/drivers/iio/dac/ad5686.h b/drivers/iio/dac/ad5686.h index e7d36bae3e59..36e16c5c4581 100644 --- a/drivers/iio/dac/ad5686.h +++ b/drivers/iio/dac/ad5686.h @@ -46,6 +46,7 @@ #define AD5310_REF_BIT_MSK BIT(8) #define AD5683_REF_BIT_MSK BIT(12) +#define AD5686_REF_BIT_MSK BIT(0) #define AD5693_REF_BIT_MSK BIT(12) /** -- 2.43.0