Re: [PATCH v2 00/11] Fixes and cleanups for the AD5686 IIO driver

Andy Shevchenko
2026-04-27T18:12:13Z

On Mon, Apr 27, 2026 at 12:30:07PM +0100, Rodrigo Alencar via B4 Relay wrote:
> This is the first series of three on updating the AD5686 driver.
>
> A bigger patch series was sent before ("Extend device support for AD5686 driver"),
> but this is not exactly a v2:
>
> https://lore.kernel.org/r/20260422-ad5313r-iio-support-v1-0-ed7dca001d1b@analog.com
>
> This one adds a number of cleanups and fixes, like:
> - Refactor include headers (IWYU);
> - Remove redundant register definition;
> - Drop enum chip id in favor of per-device chip_info structs;
> - Fix internal voltage reference control for single-channel devices;
> - Acquire lock when doing power down control;
> - Fix powerdown control for dual-channel devices;

I have only a few nit-picks, in general LGTM, thanks!

--
With Best Regards,
Andy Shevchenko