Re: [PATCH v4 3/7] iio: adc: hx711: update Kconfig, module description and file header

Andy Shevchenko
2026-04-27T14:19:25Z

On Mon, Apr 27, 2026 at 04:58:03PM +0300, Andy Shevchenko wrote:
> On Mon, Apr 27, 2026 at 03:39:34PM +0530, Piyush Patle wrote:
> > Update the Kconfig entry to "AVIA HX711 and compatible ADCs" and list
> > supported chips one per line to make it easy to extend when new variants
> > are added. Change the module description and file header to match.
> >
> > Add direct includes for linux/array_size.h and linux/types.h rather than
> > relying on transitive includes pulled in by other headers.
>
> Obviously something went wrong. First of all, I have told that MODULE_*()
> changes doesn't belong to the refactoring patch. Second, I meant that the
> Kconfig help text to go to a separate patch.
>
> Header inclusions should be taken care when it's required. It doesn't belong
> here.
>
> Looking at this again, most of it probably should be folded into the new HW
> support patch where you add a new chip_info.

I checked again after browsing through the whole series. This patch basically
should be either folded to the patch 7, or immediately prepend that (without
being any between them).

- Kconfig + MODULE_*() + respective comments update
// no patches in between!
- new HW support

--
With Best Regards,
Andy Shevchenko