From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC2D53469EE; Mon, 27 Apr 2026 20:14:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320867; cv=none; b=fQgIyen57BGrr+ICK9pcTI6KsrHfgX6G+Y+181gMNI+W1X9VBD4l506REwpfLw8aKcs8qZHpddA+YNXaqVcVOU/7h2yg53daWaCYXBKtcwYoVLgC08iE8G6CS3k46qhkgAgrQbs33GBmfwSparGCicNSJpJBDCo8CUhtbTbkKF8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320867; c=relaxed/simple; bh=VkVmyO1sLvnbDxjsT7g5r6+v42hON4p4F1cx/O8dadc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Hkc/uywKQBcJ+ST9+5C44RYmBRzzxcz7H0j5ufgRQV236FIfUrKvjurdKS9OsO+FauUvrTnMCy/wpBvvCrHiFChgfYeB32EDo2rjH9KqAoHVKkwtTCiFVKbIgfaTXsBLu+LcgMikuAmLYhgsV1wBHw5+Fx+cWaZ0Rz3hMMqd040= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=LvvUKDkd; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LvvUKDkd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777320866; x=1808856866; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VkVmyO1sLvnbDxjsT7g5r6+v42hON4p4F1cx/O8dadc=; b=LvvUKDkdun8IJIgTVzaWyFhwh6bfrHKrt+obQkt6sZ/FccpclZMN0cp9 4KM8Mubzq/7c0y5MWJpTrt9eZXNmO35ah3xsqGaOSt92SEJCPtPUNTG3g vXhgBE2701rNYmvU8SOJ0RYupxK6Ty2lULBOekkyTzhQXNrmB5kiSiOiD BOgyxXZhNybtHb0gouzNb2JEIuQGsTDkk3RjEg5/T8rGvUyt4HRA8hlq3 VoEDuiWyaQ0DJMXbF0D+8WQ+fHerENt8/2cbiQnz1VK67M6e20YRUp84V lV5Opfq3YASesIdaihUd8Pyqo0gUGvv/3qFWGgDZW8/ZQcduBOXEyLL6T w==; X-CSE-ConnectionGUID: T8yx+tPtRGmHilq5shUUHg== X-CSE-MsgGUID: 2VyGv/HaRRmbIIQ5ovDjFQ== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="78138368" X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="78138368" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2026 13:14:23 -0700 X-CSE-ConnectionGUID: ht2je8quSRy5zrvVndXUKw== X-CSE-MsgGUID: WY+CS4wxTHKkPvfx0ZfF/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,202,1770624000"; d="scan'208";a="238074773" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa004.jf.intel.com with ESMTP; 27 Apr 2026 13:14:21 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 83624AA; Mon, 27 Apr 2026 22:14:17 +0200 (CEST) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Joshua Crofts Subject: [PATCH v0 14/14] iio: magnetometer: ak8975: Make use of the macros from bits.h Date: Mon, 27 Apr 2026 22:09:59 +0200 Message-ID: <20260427201412.3067235-15-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> References: <20260427201412.3067235-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make use of BIT() and GENMASK() where it makes sense. Signed-off-by: Andy Shevchenko --- drivers/iio/magnetometer/ak8975.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c index e6ca30b36965..4e53c61c8d69 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -46,7 +46,7 @@ #define AK8975_REG_ST1 0x02 #define AK8975_REG_ST1_DRDY_SHIFT 0 -#define AK8975_REG_ST1_DRDY_MASK (1 << AK8975_REG_ST1_DRDY_SHIFT) +#define AK8975_REG_ST1_DRDY_MASK BIT(0) #define AK8975_REG_HXL 0x03 #define AK8975_REG_HXH 0x04 @@ -56,14 +56,14 @@ #define AK8975_REG_HZH 0x08 #define AK8975_REG_ST2 0x09 #define AK8975_REG_ST2_DERR_SHIFT 2 -#define AK8975_REG_ST2_DERR_MASK (1 << AK8975_REG_ST2_DERR_SHIFT) +#define AK8975_REG_ST2_DERR_MASK BIT(2) #define AK8975_REG_ST2_HOFL_SHIFT 3 -#define AK8975_REG_ST2_HOFL_MASK (1 << AK8975_REG_ST2_HOFL_SHIFT) +#define AK8975_REG_ST2_HOFL_MASK BIT(3) #define AK8975_REG_CNTL 0x0A #define AK8975_REG_CNTL_MODE_SHIFT 0 -#define AK8975_REG_CNTL_MODE_MASK (0xF << AK8975_REG_CNTL_MODE_SHIFT) +#define AK8975_REG_CNTL_MODE_MASK GENMASK(3, 0) #define AK8975_REG_CNTL_MODE_POWER_DOWN 0x00 #define AK8975_REG_CNTL_MODE_ONCE 0x01 #define AK8975_REG_CNTL_MODE_SELF_TEST 0x08 @@ -96,7 +96,7 @@ #define AK09912_REG_ST1 0x10 #define AK09912_REG_ST1_DRDY_SHIFT 0 -#define AK09912_REG_ST1_DRDY_MASK (1 << AK09912_REG_ST1_DRDY_SHIFT) +#define AK09912_REG_ST1_DRDY_MASK BIT(0) #define AK09912_REG_HXL 0x11 #define AK09912_REG_HXH 0x12 @@ -108,7 +108,7 @@ #define AK09912_REG_ST2 0x18 #define AK09912_REG_ST2_HOFL_SHIFT 3 -#define AK09912_REG_ST2_HOFL_MASK (1 << AK09912_REG_ST2_HOFL_SHIFT) +#define AK09912_REG_ST2_HOFL_MASK BIT(3) #define AK09912_REG_CNTL1 0x30 @@ -118,7 +118,7 @@ #define AK09912_REG_CNTL_MODE_SELF_TEST 0x10 #define AK09912_REG_CNTL_MODE_FUSE_ROM 0x1F #define AK09912_REG_CNTL2_MODE_SHIFT 0 -#define AK09912_REG_CNTL2_MODE_MASK (0x1F << AK09912_REG_CNTL2_MODE_SHIFT) +#define AK09912_REG_CNTL2_MODE_MASK GENMASK(4, 0) #define AK09912_REG_CNTL3 0x32 @@ -829,7 +829,7 @@ static const struct iio_chan_spec ak8975_channels[] = { IIO_CHAN_SOFT_TIMESTAMP(3), }; -static const unsigned long ak8975_scan_masks[] = { 0x7, 0 }; +static const unsigned long ak8975_scan_masks[] = { GENMASK(2, 0), 0 }; static const struct iio_info ak8975_info = { .read_raw = &ak8975_read_raw, -- 2.50.1