From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34520330D23; Tue, 28 Apr 2026 17:02:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777395739; cv=none; b=t8jsYJYGRpQLgv52t1OhZIh+lifag1H3E44+WiGIPDiLMtJPCG9yBhu+PCmu2jlf92DzMRRxrQ4WkoGm05ok5hisDa9uvWakYi2NLneqauIlY0Sm3sDnw2zd0Jkd4RPgGDsKmW/qjyIrq0Die8q47P8Xz41D6uTjO1muwhZMVc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777395739; c=relaxed/simple; bh=rxfu7XMJ7z3UzfD8sKx/uhY/Eiv1RvvXgati5CCfXv8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PK2nHPZ26qZqOK4gpEHGrplm556B9bW6Km+CSPalHY/cSlv4PdE3Uy7D6rdQtJGDlA4TPg5jo++eqpiwYZ49iPQiXBllEUjVhskmnCyZrdCB1bnO9CdozIAlalqEuwFcg9cY7tQLecbAQ8cBpiHQL9bVqvZLTzbn8kvN80zGBP0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UzwZ4reQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UzwZ4reQ" Received: by smtp.kernel.org (Postfix) with ESMTPS id D8F1AC2BCB7; Tue, 28 Apr 2026 17:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777395738; bh=rxfu7XMJ7z3UzfD8sKx/uhY/Eiv1RvvXgati5CCfXv8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=UzwZ4reQvb57FCwtHWmmiIBi8UzP7fRoxsZ0ITdM1Fe+GZwlInSLvSP50sLge4imK KTKj+rh8pOTBOJ0oFOr4okyO3xRr7d5QsNXDEBm1KNPuPqjSXOZLlwfD2G3mQTAYDd SQ1w/jvY4CZetbdC7TEjXCvCmSs7ii8qmzfR1H6WW10CKxJR7EoZD9oxNRcf5sIuKJ PtsNWuZp3amXtR6A7NsfnEsG/qWK+JJC8TtsMbu0iFUZ3wSXd51tg/LHzEBpuocZ7g s2OOn7W3ewbjtX/jorO1pgi52JP9vf9SBciHQGwA7+wNvVfmtCMFj4MOONF2N/Ewl2 NdgyYc9DgLXBw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7A5CFF886D; Tue, 28 Apr 2026 17:02:18 +0000 (UTC) From: Rodrigo Alencar via B4 Relay Date: Tue, 28 Apr 2026 18:02:16 +0100 Subject: [PATCH v3 01/11] iio: dac: ad5686: fix ref bit initialization for single-channel parts Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260428-ad5686-fixes-v3-1-9cff7bd67a15@analog.com> References: <20260428-ad5686-fixes-v3-0-9cff7bd67a15@analog.com> In-Reply-To: <20260428-ad5686-fixes-v3-0-9cff7bd67a15@analog.com> To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Popa , Jonathan Cameron , Greg Kroah-Hartman , Michael Auchter , Jonathan Cameron Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , Andy Shevchenko , Rodrigo Alencar X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777395737; l=1785; i=rodrigo.alencar@analog.com; s=default; h=from:subject:message-id; bh=Nconrz7dK97kTaVAe2gd8GJ1K9ckwdIVrWzVZiHhK/A=; b=MVAnyZdg6ffA2JMYIaahewQ/h8qr1iLw1tkGlLl88y14KGgLexsjSRojXFdLbpylDaFfUrcIK QtMYX1WIbc8BYdrgxpJWqMxmmogrFcSk5r/vjrQJv8oFEeftPe7kl1J X-Developer-Key: i=rodrigo.alencar@analog.com; a=ed25519; pk=ULeHbgU/OYh/PG/4anHDfLgldFItQHAhOktYRVLMFRo= X-Endpoint-Received: by B4 Relay for rodrigo.alencar@analog.com/default with auth_id=561 X-Original-From: Rodrigo Alencar Reply-To: rodrigo.alencar@analog.com From: Rodrigo Alencar The reference bit position was ignored when writing the register at the probe() function (!!val was used). When such bit is 1, internal voltage reference is disabled so that an external one can be used. For multi-channel devices, bit 0 of the Internal Reference Setup command behaves the same way, so AD5686_REF_BIT_MSK is created. The issue exists since support for single-channel devices were first introduced. Fixes: be1b24d24541 ("iio:dac:ad5686: Add AD5691R/AD5692R/AD5693/AD5693R support") Signed-off-by: Rodrigo Alencar --- drivers/iio/dac/ad5686.c | 6 +++--- drivers/iio/dac/ad5686.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c index 9a384c50929b..1fc54c38b629 100644 --- a/drivers/iio/dac/ad5686.c +++ b/drivers/iio/dac/ad5686.c @@ -511,7 +511,7 @@ int ad5686_probe(struct device *dev, break; case AD5686_REGMAP: cmd = AD5686_CMD_INTERNAL_REFER_SETUP; - ref_bit_msk = 0; + ref_bit_msk = AD5686_REF_BIT_MSK; break; case AD5693_REGMAP: cmd = AD5686_CMD_CONTROL_REG; @@ -522,9 +522,9 @@ int ad5686_probe(struct device *dev, return -EINVAL; } - val = (has_external_vref | ref_bit_msk); + val = has_external_vref ? ref_bit_msk : 0; - ret = st->write(st, cmd, 0, !!val); + ret = st->write(st, cmd, 0, val); if (ret) return ret; diff --git a/drivers/iio/dac/ad5686.h b/drivers/iio/dac/ad5686.h index e7d36bae3e59..36e16c5c4581 100644 --- a/drivers/iio/dac/ad5686.h +++ b/drivers/iio/dac/ad5686.h @@ -46,6 +46,7 @@ #define AD5310_REF_BIT_MSK BIT(8) #define AD5683_REF_BIT_MSK BIT(12) +#define AD5686_REF_BIT_MSK BIT(0) #define AD5693_REF_BIT_MSK BIT(12) /** -- 2.43.0