Re: [PATCH 02/10] iio: orientation: adapt to hid_sensor_remove_trigger() API change

Andy Shevchenko
2026-04-28T08:22:53Z

On Tue, Apr 28, 2026 at 12:46:05PM +0530, Sanjay Chitroda wrote:

> Update the driver to match the updated hid_sensor_remove_trigger()
> prototype, which no longer requires struct iio_dev.

You haven't compiled the previous patch, right?
This is not the way how all this should be done.

Also NAK to the patch 1 as even unused parameter is there for the sake of
consistency. The prototype to allocate and other in the similar group all
have it.

--
With Best Regards,
Andy Shevchenko