Re: [PATCH v2 1/4] iio: magnetometer: rm3100: Use guard(mutex)() in rm3100_read_mag()

Jonathan Cameron
2026-04-28T15:59:03Z

On Tue, 28 Apr 2026 09:59:55 -0500
Maxwell Doose <m32285159@gmail.com> wrote:

> On Tue, Apr 28, 2026 at 8:26 AM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> >
> > Perhaps we need to also put a summary of the extended critical section, so that
> > it will be clear that we thought about it and decided to cover that small memory
> > access + some bitops.
> >
> > Otherwise LGTM.
> >
>
> Sounds good, but I'm going to wait 1 or 2 days to see if a maintainer
> wants to comment on whether or not we *need* the summary about the
> mutex scope. If they don't say anything I'll probably just send a v3
> with the summary added in the commit message.

Where scope changes, it is indeed good to add a brief note on what
ends up incorporated in the expanded scope and whether that is worth
thinking about or not when reviewing the patch.

Here I think it's easy to conclude we don't care. The last patch not
so much!

J
>
> best regards,
> maxwell