From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Salah Triki" <salah.triki@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] iio: dac: max5821: fix return value check in powerdown sync
Date: Tue, 28 Apr 2026 17:12:44 +0100 [thread overview]
Message-ID: <20260428171244.5bf16bb5@jic23-huawei> (raw)
In-Reply-To: <afBoARByF0W3gS6k@ashevche-desk.local>
On Tue, 28 Apr 2026 10:55:45 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Mon, Apr 27, 2026 at 10:33:19PM +0100, Salah Triki wrote:
> > The function max5821_sync_powerdown_mode() returned the result of
> > i2c_master_send() directly. If a partial transfer occurred, it would
> > be incorrectly treated as a success by the caller.
> >
> > While the caller currently handles the positive return value of 2 as
> > success, this patch refactors the function to return 0 on full success
> > and -EIO on short writes. This ensures robust error handling for
> > incomplete transfers and improves code maintainability by using
> > sizeof(outbuf).
>
> Makes sense, FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
Applied and marked for stable.
prev parent reply other threads:[~2026-04-28 16:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 21:33 [PATCH v3] iio: dac: max5821: fix return value check in powerdown sync Salah Triki
2026-04-28 7:55 ` Andy Shevchenko
2026-04-28 16:12 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428171244.5bf16bb5@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox