From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Subject: Re: [PATCH v1 1/1] iio: buffer: Move from int64_t to s64 for timestamp
Date: Tue, 28 Apr 2026 17:37:06 +0100 [thread overview]
Message-ID: <20260428173706.29b5cf3e@jic23-huawei> (raw)
In-Reply-To: <20260427185147.3016331-1-andriy.shevchenko@linux.intel.com>
On Mon, 27 Apr 2026 20:51:47 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> iio_push_to_buffers_with_ts_unaligned() uses int64_t for timestamp.
> Move it from int64_t to s64 to make consistent with:
> - iio_push_to_buffers_with_ts()
> - all current users that supply s64 anyway
>
> This will reduce potential of wrong type being chosen when using
> this API.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
I was being overly optimistic and thinking we'd get rid of this ABI by
now so not worth fixing. That's going a bit slow, so fair enough.
Applied.
Thanks,
Jonathan
> ---
> drivers/iio/industrialio-buffer.c | 2 +-
> include/linux/iio/buffer.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index 46f36a6ed271..6d92295422be 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -2422,7 +2422,7 @@ EXPORT_SYMBOL_GPL(iio_push_to_buffers);
> int iio_push_to_buffers_with_ts_unaligned(struct iio_dev *indio_dev,
> const void *data,
> size_t data_sz,
> - int64_t timestamp)
> + s64 timestamp)
> {
> struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
>
> diff --git a/include/linux/iio/buffer.h b/include/linux/iio/buffer.h
> index d37f82678f71..e0344d51b4f9 100644
> --- a/include/linux/iio/buffer.h
> +++ b/include/linux/iio/buffer.h
> @@ -71,7 +71,7 @@ static inline int iio_push_to_buffers_with_ts(struct iio_dev *indio_dev,
>
> int iio_push_to_buffers_with_ts_unaligned(struct iio_dev *indio_dev,
> const void *data, size_t data_sz,
> - int64_t timestamp);
> + s64 timestamp);
>
> bool iio_validate_scan_mask_onehot(struct iio_dev *indio_dev,
> const unsigned long *mask);
prev parent reply other threads:[~2026-04-28 16:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 18:51 [PATCH v1 1/1] iio: buffer: Move from int64_t to s64 for timestamp Andy Shevchenko
2026-04-28 16:37 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428173706.29b5cf3e@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox