From: Miao Li <limiao870622@163.com>
To: jic23@kernel.org, andy@kernel.org
Cc: dixitparmar19@gmail.com, dlechner@baylibre.com,
nuno.sa@analog.com, waqar.hameed@axis.com, limiao870622@163.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH v2] iio: light: stk3310: Deal with the ps interrupt issue in PM
Date: Wed, 29 Apr 2026 15:50:42 +0800 [thread overview]
Message-ID: <20260429075042.214768-1-limiao870622@163.com> (raw)
In-Reply-To: <afGsN5RDDQJZt8ok@ashevche-desk.local>
> > struct mutex lock;
> > bool als_enabled;
> > bool ps_enabled;
> > + bool ps_int_enabled;
> > + uint32_t ps_thdl;
> > + uint32_t ps_thdh;
>
> I still think we shouldn't add more {u}intXX_t into the drivers.
> Just add a patch on top of this to clean up those types to use
> kernel regular ones (uXX/sXX) instead.
>
> > uint32_t ps_near_level;
> > u64 timestamp;
> > struct regmap *regmap;
>
> I also haven't seen the response on `pahole` run. Is that tool happy with
> the proposed layout?
Hi, Andy
Patch v3 only fixes a few syntax errors in the function resume()
that were introduced by patch v2,
what you said I will revise at patch v4.
Best Regards.
next prev parent reply other threads:[~2026-04-29 7:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 9:43 [PATCH] iio: light: stk3310: Deal with the ps interrupt issue in PM Miao Li
2026-04-27 9:56 ` Andy Shevchenko
2026-04-27 10:13 ` Joshua Crofts
2026-04-28 18:22 ` Jonathan Cameron
2026-04-29 6:18 ` Miao Li
2026-04-29 6:45 ` Miao Li
2026-04-29 6:51 ` [PATCH v2] " Miao Li
2026-04-29 6:59 ` Andy Shevchenko
2026-04-29 7:50 ` Miao Li [this message]
2026-04-29 7:14 ` [PATCH v3] " Miao Li
2026-04-29 9:03 ` Andy Shevchenko
2026-04-29 9:19 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260429075042.214768-1-limiao870622@163.com \
--to=limiao870622@163.com \
--cc=andy@kernel.org \
--cc=dixitparmar19@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox