From: Angus Gardner <angusg778@gmail.com>
To: linux-iio@vger.kernel.org
Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org,
jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com
Subject: [PATCH 1/3] staging: iio: ad9834: simplify -ENOMEM return in probe
Date: Mon, 4 May 2026 19:20:57 +1000 [thread overview]
Message-ID: <20260504092059.1536094-2-angusg778@gmail.com> (raw)
In-Reply-To: <20260504092059.1536094-1-angusg778@gmail.com>
devm_iio_device_alloc() failure returns -ENOMEM via a local variable
unnecessarily. Return -ENOMEM directly instead.
Signed-off-by: Angus Gardner <angusg778@gmail.com>
---
drivers/staging/iio/frequency/ad9834.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c
index bdb2580e29bf..f2bf7123ffcf 100644
--- a/drivers/staging/iio/frequency/ad9834.c
+++ b/drivers/staging/iio/frequency/ad9834.c
@@ -389,10 +389,8 @@ static int ad9834_probe(struct spi_device *spi)
return dev_err_probe(&spi->dev, ret, "Failed to enable specified AVDD supply\n");
indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
- if (!indio_dev) {
- ret = -ENOMEM;
- return ret;
- }
+ if (!indio_dev)
+ return -ENOMEM;
st = iio_priv(indio_dev);
mutex_init(&st->lock);
st->mclk = devm_clk_get_enabled(&spi->dev, NULL);
--
2.51.0
next prev parent reply other threads:[~2026-05-04 9:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 9:20 [PATCH v2 0/3] staging: iio: ad9834: driver cleanup Angus Gardner
2026-05-04 9:20 ` Angus Gardner [this message]
2026-05-04 12:37 ` [PATCH 1/3] staging: iio: ad9834: simplify -ENOMEM return in probe Maxwell Doose
2026-05-04 9:20 ` [PATCH 2/3] staging: iio: ad9834: use dev_err_probe() in probe function Angus Gardner
2026-05-04 9:20 ` [PATCH 3/3] staging: iio: ad9834: fix chip name typo in comments Angus Gardner
2026-05-04 12:33 ` Maxwell Doose
2026-05-04 15:23 ` [PATCH v2 0/3] staging: iio: ad9834: driver cleanup Jonathan Cameron
2026-05-04 16:10 ` Maxwell Doose
2026-05-04 16:54 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504092059.1536094-2-angusg778@gmail.com \
--to=angusg778@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox