From: Joshua Crofts via B4 Relay <devnull+joshua.crofts1.gmail.com@kernel.org>
To: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Joshua Crofts <joshua.crofts1@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v5 13/18] iio: magnetometer: ak8975: unify return code variable name
Date: Tue, 05 May 2026 13:46:09 +0200 [thread overview]
Message-ID: <20260505-magnetometer-fixes-v5-13-831b9b5550fc@gmail.com> (raw)
In-Reply-To: <20260505-magnetometer-fixes-v5-0-831b9b5550fc@gmail.com>
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
In one case 'rc' is used in the other 'err', the most use 'ret'.
Make the latter use the former, id est 'ret'.
While at it, drop unneeded ' < 0' checks.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
drivers/iio/magnetometer/ak8975.c | 46 +++++++++++++++++++--------------------
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index fd42e20cd145860bdd1b143409de24b7145f8252..1c05e380a4d4f968f505a7d5c0acbec86ad949e1 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -573,8 +573,8 @@ static irqreturn_t ak8975_irq_handler(int irq, void *data)
static int ak8975_setup_irq(struct ak8975_data *data)
{
struct i2c_client *client = data->client;
- int rc;
int irq;
+ int ret;
init_waitqueue_head(&data->data_ready_queue);
clear_bit(0, &data->flags);
@@ -583,15 +583,15 @@ static int ak8975_setup_irq(struct ak8975_data *data)
else
irq = gpiod_to_irq(data->eoc_gpiod);
- rc = devm_request_irq(&client->dev, irq, ak8975_irq_handler,
- IRQF_TRIGGER_RISING,
- dev_name(&client->dev), data);
- if (rc < 0)
- return rc;
+ ret = devm_request_irq(&client->dev, irq, ak8975_irq_handler,
+ IRQF_TRIGGER_RISING,
+ dev_name(&client->dev), data);
+ if (ret)
+ return ret;
data->eoc_irq = irq;
- return rc;
+ return 0;
}
/*
@@ -907,8 +907,8 @@ static int ak8975_probe(struct i2c_client *client)
struct iio_dev *indio_dev;
struct gpio_desc *eoc_gpiod;
struct gpio_desc *reset_gpiod;
- int err;
const char *name = NULL;
+ int ret;
/*
* Grab and set up the supplied GPIO.
@@ -943,9 +943,9 @@ static int ak8975_probe(struct i2c_client *client)
data->reset_gpiod = reset_gpiod;
data->eoc_irq = 0;
- err = iio_read_mount_matrix(&client->dev, &data->orientation);
- if (err)
- return err;
+ ret = iio_read_mount_matrix(&client->dev, &data->orientation);
+ if (ret)
+ return ret;
/* id will be NULL when enumerated via ACPI */
data->def = i2c_get_match_data(client);
@@ -966,20 +966,20 @@ static int ak8975_probe(struct i2c_client *client)
if (IS_ERR(data->vid))
return PTR_ERR(data->vid);
- err = ak8975_power_on(data);
- if (err)
- return err;
+ ret = ak8975_power_on(data);
+ if (ret)
+ return ret;
- err = ak8975_who_i_am(client, data->def->type);
- if (err < 0) {
+ ret = ak8975_who_i_am(client, data->def->type);
+ if (ret) {
dev_err(&client->dev, "Unexpected device\n");
goto power_off;
}
dev_dbg(&client->dev, "Asahi compass chip %s\n", name);
/* Perform some basic start-of-day setup of the device. */
- err = ak8975_setup(client);
- if (err < 0) {
+ ret = ak8975_setup(client);
+ if (ret) {
dev_err(&client->dev, "%s initialization fails\n", name);
goto power_off;
}
@@ -992,15 +992,15 @@ static int ak8975_probe(struct i2c_client *client)
indio_dev->modes = INDIO_DIRECT_MODE;
indio_dev->name = name;
- err = iio_triggered_buffer_setup(indio_dev, NULL, ak8975_handle_trigger,
+ ret = iio_triggered_buffer_setup(indio_dev, NULL, ak8975_handle_trigger,
NULL);
- if (err) {
+ if (ret) {
dev_err(&client->dev, "triggered buffer setup failed\n");
goto power_off;
}
- err = iio_device_register(indio_dev);
- if (err) {
+ ret = iio_device_register(indio_dev);
+ if (ret) {
dev_err(&client->dev, "device register failed\n");
goto cleanup_buffer;
}
@@ -1023,7 +1023,7 @@ static int ak8975_probe(struct i2c_client *client)
iio_triggered_buffer_cleanup(indio_dev);
power_off:
ak8975_power_off(data);
- return err;
+ return ret;
}
static void ak8975_remove(struct i2c_client *client)
--
2.47.3
next prev parent reply other threads:[~2026-05-05 11:46 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 11:45 [PATCH v5 00/18] iio: magnetometer: ak8975: modernize and cleanup driver Joshua Crofts via B4 Relay
2026-05-05 11:45 ` [PATCH v5 01/18] iio: magnetometer: ak8975: sort headers alphabetically Joshua Crofts via B4 Relay
2026-05-05 23:46 ` Maxwell Doose
2026-05-06 16:36 ` Jonathan Cameron
2026-05-05 11:45 ` [PATCH v5 02/18] iio: magnetometer: ak8975: update headers per IWYU principle Joshua Crofts via B4 Relay
2026-05-06 0:38 ` Maxwell Doose
2026-05-06 16:37 ` Jonathan Cameron
2026-05-05 11:45 ` [PATCH v5 03/18] iio: magnetometer: ak8975: replace usleep_range() with fsleep() Joshua Crofts via B4 Relay
2026-05-05 20:30 ` Maxwell Doose
2026-05-05 21:26 ` Joshua Crofts
2026-05-05 21:42 ` Maxwell Doose
2026-05-05 21:59 ` Joshua Crofts
2026-05-05 22:12 ` Maxwell Doose
2026-05-06 6:19 ` Andy Shevchenko
2026-05-06 6:35 ` Maxwell Doose
2026-05-06 16:39 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 04/18] iio: magnetometer: ak8975: change 'u8*' to 'u8 *' in cast Joshua Crofts via B4 Relay
2026-05-06 0:47 ` Maxwell Doose
2026-05-06 6:30 ` Andy Shevchenko
2026-05-06 16:40 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 05/18] iio: magnetometer: ak8975: fix wrong errno on return Joshua Crofts via B4 Relay
2026-05-06 16:41 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 06/18] iio: magnetometer: ak8975: pass conversion timeouts as arguments Joshua Crofts via B4 Relay
2026-05-06 6:34 ` Andy Shevchenko
2026-05-06 7:02 ` Joshua Crofts
2026-05-06 7:20 ` Andy Shevchenko
2026-05-06 7:28 ` Joshua Crofts
2026-05-06 7:32 ` Andy Shevchenko
2026-05-06 16:51 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 07/18] iio: magnetometer: ak8975: modernize polling loops with iopoll() macros Joshua Crofts via B4 Relay
2026-05-06 6:53 ` Andy Shevchenko
2026-05-06 7:01 ` Joshua Crofts
2026-05-06 10:50 ` Joshua Crofts
2026-05-06 13:08 ` Andy Shevchenko
2026-05-06 16:52 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 08/18] iio: magnetometer: ak8975: check if gpiod read was successful Joshua Crofts via B4 Relay
2026-05-06 1:09 ` Maxwell Doose
2026-05-06 1:42 ` Maxwell Doose
2026-05-06 7:11 ` Andy Shevchenko
2026-05-06 7:13 ` Maxwell Doose
2026-05-06 7:16 ` Andy Shevchenko
2026-05-06 7:21 ` Maxwell Doose
2026-05-06 7:31 ` Joshua Crofts
2026-05-06 7:05 ` Joshua Crofts
2026-05-06 16:48 ` Jonathan Cameron
2026-05-06 7:07 ` Andy Shevchenko
2026-05-06 7:11 ` Maxwell Doose
2026-05-06 6:53 ` Andy Shevchenko
2026-05-06 7:07 ` Joshua Crofts
2026-05-05 11:46 ` [PATCH v5 09/18] iio: magnetometer: ak8975: avoid using temporary variable Joshua Crofts via B4 Relay
2026-05-06 16:54 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 10/18] iio: magnetometer: ak8975: drop duplicate NULL check Joshua Crofts via B4 Relay
2026-05-06 16:55 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 11/18] iio: magnetometer: ak8975: remove duplicate error message Joshua Crofts via B4 Relay
2026-05-06 16:56 ` Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 12/18] iio: magnetometer: ak8975: reduce usage of magic lengths of the buffer Joshua Crofts via B4 Relay
2026-05-06 16:56 ` Jonathan Cameron
2026-05-05 11:46 ` Joshua Crofts via B4 Relay [this message]
2026-05-06 16:57 ` [PATCH v5 13/18] iio: magnetometer: ak8975: unify return code variable name Jonathan Cameron
2026-05-05 11:46 ` [PATCH v5 14/18] iio: magnetometer: ak8975: switch to using managed resources Joshua Crofts via B4 Relay
2026-05-05 14:34 ` Joshua Crofts
2026-05-06 8:21 ` Andy Shevchenko
2026-05-06 17:09 ` Jonathan Cameron
2026-05-07 9:19 ` Joshua Crofts
2026-05-07 10:09 ` Andy Shevchenko
2026-05-07 10:14 ` Joshua Crofts
2026-05-07 12:11 ` Andy Shevchenko
2026-05-07 12:24 ` Joshua Crofts
2026-05-05 11:46 ` [PATCH v5 15/18] iio: magnetometer: ak8975: consistently use 'data' parameter Joshua Crofts via B4 Relay
2026-05-05 11:46 ` [PATCH v5 16/18] iio: magnetometer: ak8975: unify messages with help of dev_err_probe() Joshua Crofts via B4 Relay
2026-05-05 11:46 ` [PATCH v5 17/18] iio: magnetometer: ak8975: use temporary variable for struct device Joshua Crofts via B4 Relay
2026-05-05 11:46 ` [PATCH v5 18/18] iio: magnetometer: ak8975: make use of the macros from bits.h Joshua Crofts via B4 Relay
2026-05-06 17:12 ` Jonathan Cameron
2026-05-06 21:25 ` Andy Shevchenko
2026-05-07 10:06 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505-magnetometer-fixes-v5-13-831b9b5550fc@gmail.com \
--to=devnull+joshua.crofts1.gmail.com@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox