From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Salah Triki" <salah.triki@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] iio: humidity: ens210: Fix missing I2C functionality checks
Date: Wed, 6 May 2026 17:20:50 +0100 [thread overview]
Message-ID: <20260506172050.45a7c35b@jic23-huawei> (raw)
In-Reply-To: <CALoEA-x9KRBu7=a4m4bxpp2c8o=MVqxr+ZpUNB8uga+XYeYX7g@mail.gmail.com>
On Wed, 6 May 2026 12:17:42 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> On Wed, 6 May 2026 at 12:13, Salah Triki <salah.triki@gmail.com> wrote:
> >
> > The ENS210 driver uses SMBus transactions (such as byte, word, and block
> > data reads/writes) during the probe and measurement phases. However, the
> > initial functionality check only validated a subset of these capabilities,
> > which could lead to loading failures on adapters requiring SMBus
> > emulation or native-only controllers.
> >
> > To ensure compatibility across a wide range of I2C adapters, modify the
> > functionality check to verify if the adapter supports the required native
> > operations or, failing that, supports the SMBus emulation layer.
> >
> > Fixes: c524fbca672e ("iio: humidity: Add support for ENS210")
> > Signed-off-by: Salah Triki <salah.triki@gmail.com>
> > ---
>
> Please slow down, you've sent two versions in the past 30 minutes.
>
> Alignment is fine, but refrain from sending patches that quickly.
>
The comments I just sent indeed applied to v2... So good advice
that you should slow down!
J
next prev parent reply other threads:[~2026-05-06 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 9:58 [PATCH v5] iio: humidity: ens210: Fix missing I2C functionality checks Salah Triki
2026-05-06 10:17 ` Joshua Crofts
2026-05-06 16:20 ` Jonathan Cameron [this message]
2026-05-06 10:38 ` Andy Shevchenko
2026-05-06 16:19 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506172050.45a7c35b@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox