From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8175B449EC4; Thu, 7 May 2026 15:28:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778167707; cv=none; b=dR9RTC1Q4Zp9/4I2B7R7CsOnw/70Kq3nmyAa6f1xo5Fd2lJUz2oiAqmZC/R/mR6TJCqd/hfD0hfJ1I6KZJqcfhZpFdYDgp/2oo77bG1TycpiKZfw6TkINoZDSAln7vpf/FZdlXexKpB0uR0HR2GGHcLc16Pzj38RrYr25/16K5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778167707; c=relaxed/simple; bh=4eOAk7Jab8Qd0kCNwcOZLlm6jgPUdg90LEM6kZcx/eo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SxU/iqT25wp63FmiW2KOJutB9GWk7wT/h2aVuTJZOF0SHzYMtyzrxqi9kTj3oxdLE8SqGIFqCZ86NyntUP0T0OAZ1u4uCDSTVRECjAOjwI11Ax6sOZ3IMJaE/BF1x95pPLZk95OhreMvw0xexhBKBSwtvcVEzrZ36bJ03XXXBsA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tsKTlNuO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tsKTlNuO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDA90C2BCB2; Thu, 7 May 2026 15:28:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778167707; bh=4eOAk7Jab8Qd0kCNwcOZLlm6jgPUdg90LEM6kZcx/eo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tsKTlNuOWmgG9OLtgI/cSdYxSyxXfVLEBh/Hx32ww+52sozgT2D19X9rI4dnCrZYZ 3KlxKsvyAhnRA38+ONp1wmPUDLN0GP04w6w+l8vft+lGDOhn78JAGJVMgipLYMcivc fToIuml6bRnmQYKd954N9uirjQcMVJhroSFWR729xxxg32rASs+NQkub4hhYXE0h60 NHb+svpZkuJgyi0dKwHLgUc37J17blwvMc8t7Ydf123NGnclFbTULRBjJtT4Ly1Ptq G9YOWeaOMCmB5XTF4GZjMlRP2MXq5nmNv3LneHX4yBzs7aILSrwtralDGUMzOKY4LI ukigsNFZWVJig== Date: Thu, 7 May 2026 16:28:15 +0100 From: Jonathan Cameron To: Angelo Dureghello Cc: Arnd Bergmann , Greg Ungerer , Geert Uytterhoeven , Steven King , Maxime Coquelin , Alexandre Torgue , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Greg Ungerer , linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, Angelo Dureghello Subject: Re: [PATCH 08/10] m68k: stmark2: add mcf5441x DAC platform devices Message-ID: <20260507162815.1135618e@jic23-huawei> In-Reply-To: References: <20260504-wip-stmark2-dac-v1-0-874c36a4910d@baylibre.com> <20260504-wip-stmark2-dac-v1-8-874c36a4910d@baylibre.com> <20260506155737.6cd625a5@jic23-huawei> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 6 May 2026 23:07:41 +0200 Angelo Dureghello wrote: > Hi Jonathan, > > On 5/6/26 16:57, Jonathan Cameron wrote: > > On Mon, 04 May 2026 19:28:28 +0200 > > "Arnd Bergmann" wrote: > > > >> On Mon, May 4, 2026, at 19:16, Angelo Dureghello wrote: > >>> @@ -94,8 +94,42 @@ static struct platform_device dspi_spi0_device = { > >> ... > >>> +static struct resource dspi_dac1_resource[] = { > >>> + [0] = { > >> > >> This looks like the name has a copy-paste error: this is not > >> related to the 'dspi' controller at all but is just the dac, right? > >> > >> Arnd > >> > > > > https://sashiko.dev/#/patchset/20260504-wip-stmark2-dac-v1-0-874c36a4910d%40baylibre.com > > Has noted some more alongside this one. > > Seems unlikely a DAC has a bus number. > > > > that sashiko comment is not clear to me, maybe was related to the comment > i copy/pasted from dspi. Yes. i think that is what it was referring to. > > I have now fixed this as: > > +static struct resource dac0_resource[] = { > + DEFINE_RES_MEM(MCFDAC_BASE0, 0x100), > +}; > + > +static struct platform_device dac0_device = { > + .name = "mcf54415_dac", > + .id = 0, > + .num_resources = ARRAY_SIZE(dac0_resource), > + .resource = dac0_resource, > +}; > + > +static struct resource dac1_resource[] = { > + DEFINE_RES_MEM(MCFDAC_BASE1, 0x100), > +}; > + > +static struct platform_device dac1_device = { > + .name = "mcf54415_dac", > + .id = 1, > + .num_resources = ARRAY_SIZE(dac1_resource), > + .resource = dac1_resource, > +}; > + > static struct platform_device *stmark2_devices[] __initdata = { > &dspi_spi0_device, > + &dac0_device, > + &dac1_device, > }; > > It should be fine for sashiko too. > > Regards, > angelo > > > Jonathan > > > > > > -- Angelo >