From: Stepan Ionichev <sozdayvek@gmail.com>
To: andy@kernel.org
Cc: giorgitchankvetadze1997@gmail.com, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, m32285159@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
sozdayvek@gmail.com
Subject: Re: [PATCH 3/3] iio: chemical: scd30: make command lookup table const
Date: Sun, 10 May 2026 05:31:36 +0500 [thread overview]
Message-ID: <20260510003136.35026-1-sozdayvek@gmail.com> (raw)
In-Reply-To: <20260509111634.21700-1-sozdayvek@gmail.com>
On Sun, 10 May 2026, Andy Shevchenko wrote:
> > scd30_i2c_cmd_lookup_tbl[] holds the fixed CMD_* opcodes and is only
> > ever read in scd30_i2c_command() (via put_unaligned_be16 of the looked
> > up entry). Marking it const matches how it is used and lets the table
> > land in .rodata.
>
> I believe the above is the suggestion on the correction of the commit message?
> Please, make it clear!
Sorry for the ambiguity -- that paragraph was just my own reasoning
for the Reviewed-by tag (i.e. what I checked and why I think the
change is correct), not a proposed rewording of the commit message.
Giorgi's commit message already reads fine; no changes requested
from me.
Stepan
next prev parent reply other threads:[~2026-05-10 7:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 13:39 [PATCH] iio: chemical: scd30: make command lookup table const Giorgi Tchankvetadze
2026-05-08 15:07 ` Maxwell Doose
2026-05-09 11:16 ` [PATCH 3/3] " Stepan Ionichev
2026-05-10 0:31 ` Stepan Ionichev [this message]
2026-05-10 0:42 ` Stepan Ionichev
2026-05-10 1:05 ` Stepan Ionichev
2026-05-10 8:04 ` Maxwell Doose
2026-05-10 9:08 ` Andy Shevchenko
2026-05-10 7:52 ` Maxwell Doose
2026-05-10 7:21 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260510003136.35026-1-sozdayvek@gmail.com \
--to=sozdayvek@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=giorgitchankvetadze1997@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m32285159@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox