From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Stepan Ionichev <sozdayvek@gmail.com>,
lars@metafoo.de, Michael.Hennerich@analog.com,
puranjay@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] iio: accel: adxl355: replace usleep_range() with fsleep()
Date: Mon, 11 May 2026 17:13:31 +0100 [thread overview]
Message-ID: <20260511171331.77f3ef39@jic23-huawei> (raw)
In-Reply-To: <agGE7F5zm2pN_dBk@ashevche-desk.local>
On Mon, 11 May 2026 10:27:40 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Sun, May 10, 2026 at 04:38:52PM +0500, Stepan Ionichev wrote:
> > The "at least 5ms" wait after software reset has no specific upper
> > bound. Use fsleep() with 5 * USEC_PER_MSEC to make the unit
> > explicit at the call site.
>
> > No functional change.
>
> Strictly speaking the upper limit is not set as 10 milliseconds now,
> but defined by the internals of fsleep(), usually +25%.
I'm not following. There doesn't seem to be a statement of anything
about the upper limit that is used - just one on it not being specified
for the part.
>
> Perhaps Jonathan can just drop this sentence from the commit message
> whilst applying.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
Given I didn't really get the comment - applied as is.
J
next prev parent reply other threads:[~2026-05-11 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 11:38 [PATCH v3] iio: accel: adxl355: replace usleep_range() with fsleep() Stepan Ionichev
2026-05-11 7:27 ` Andy Shevchenko
2026-05-11 16:13 ` Jonathan Cameron [this message]
2026-05-12 7:32 ` Andy Shevchenko
2026-05-12 11:26 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511171331.77f3ef39@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=puranjay@kernel.org \
--cc=sozdayvek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox