From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 065E272621 for ; Tue, 12 May 2026 01:23:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778549015; cv=none; b=TClT/B8Qe2qmrx80Eqfc9npiZ4bvoGvYTFEcF5Caw55u2UuHC3YJZ+4LFJb2eU6Q4fdNlIcnqX8irFX9dg5mRQD04bXoLxVpVJl5PTWt1gaKTvnesCaDEJxBOBGsPp1yx9xqynXFSpg7Ginx3rt/wnUMggIZ9SUB6FZ7/G8Fm8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778549015; c=relaxed/simple; bh=t62DpAaPNnoZZ/jlZXdUjwjPRqbxjIgCXI2RGSb7HZk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=A5T6704idzlp8kO5UCbR8Lg/HbW478XNYRsHerynxJ59TpdsUyGQTpqasbB7z+lOgyhjFtmnihZJFqLVhK+CWI29bedgCHEoHqaPj4TYcMT46gmni/dc6QzhTgsINL8MkioShKCap8835DkWs8fRK0OFnBnBv+cM2k1AuGCaYVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ime.usp.br; spf=pass smtp.mailfrom=ime.usp.br; dkim=pass (2048-bit key) header.d=usp.br header.i=@usp.br header.b=XbZOu6L8; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ime.usp.br Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ime.usp.br Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=usp.br header.i=@usp.br header.b="XbZOu6L8" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-2ecf9e398f4so13482465eec.1 for ; Mon, 11 May 2026 18:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; t=1778549013; x=1779153813; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ySljj7grGzorfpQDQF+Okz8TP5DcbgRvn1q/VrsxZlA=; b=XbZOu6L88P83ChbD1fOpwESoJBXG43pQzgqJxkk6YrjNIkq2l9P5qJZoUh8K32gSqJ 8jC46/4cWFFKnbHC+9jvn6PXrlNfdnBEzMQuX3xGbT5ZM07dWH0bLrI8tMHeRnz65LKU S138K9338FZIfYITn/MfhjMThSbnd9e1dmM8Pv3CuA/xpCpoL1E2RfnRKTsaBVgHI8j+ +iyLqcSBVRg0lMKpqWPnms71NEhE+5Jvl/xODN9Znm42yAqMTATjHcHKWuV+6ytJU1oc 4/NoVj7wIk3uSQoKeOF0MY2r3m66hmFFygOMDF9aSaWeJty2A+32sWQ3SGTmBWBYIJLA adag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778549013; x=1779153813; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ySljj7grGzorfpQDQF+Okz8TP5DcbgRvn1q/VrsxZlA=; b=TV8JllDLu3arLzT+V2jvGQpsqrpLGVbLHWCXPNdfrMWwqPsQfwSXpfd+e4BuQOAiNX Fy9lL/QUSD9aLyRMz7fVZu5ONv2JIRxWq2oBueQG3CjAO8zZQMEmFENalOKSrv9hKV5z h4aUZDcYtqrL1z/SlLEZ/FUV9ibwx6ygjnzZpqK4rrRc4kEf6yKVFASBqje4TOUBOGlw llFdaq9ufC7C5JY+9J1cPsLn5daio/dDOTesjRjhe/ILp1Fcnnnwy6elMNqfiomPFKI6 NP3hFDIRRmpExVqmq+rEXeJeJohMWUA0bI73RnlHSW5SvYN2kvQGIPOfW5lNFMhAJk3i OKuA== X-Forwarded-Encrypted: i=1; AFNElJ8BGQAz2k8/ym74YlATROw30Gdnw82PVkXj9AJeraTRciEHm037ZFuWWdNXJjVjrCB7qFzwd5VYWNw=@vger.kernel.org X-Gm-Message-State: AOJu0YxnN/feXd2ffGwnRq85uXeXCw73p+sD5ffKfZnM8rqhnY0FP+w1 m/xmpUfYG/iywNyiKZZM60F4HuJAK5M8eoJEkDfmCr3HdQ0g8p3AfesVqxs77lSzx84= X-Gm-Gg: Acq92OG23PQKreIeR5Z1K9YrG5AzCpRHrtL+nT/oS9XCvvkenrws/RcNUqgA1JtfapT Y9HDUr8s6/zkJkvaOw+7Uslynd+x11CKrB3XhyoIiebZcZ7NlGzcAnIrTbQ0YuwfdYRqRZaFkAj 1OcjpBQJdHJgvJAyNz4tzbAr4Ch307mQLQLs8TpgFU/sysUBhvYb2nMjp/KZrzILlFQ3V8O9mDp uRcUbwSlFKk8QdsrxKW+41vC+pmlGrgdjWVkiWY7eHIXRNUCYey1/IibolQwA5ib/t4ngaFcfsE Y4L2WMgqqXxgnn2U4BZCJ49DkfgwBT0M5+huASxDBAsvWJkAFi8lazA3vqNQosDgStdt+9FcFfC /yNaJ1Oi57wFC95Nbc2mobEQBjOugAdyaZztQRbcp/I3WHLx9WW0OOF+GSmlDjt+o8I86EKQo48 KXORXq5Lm4VJ/eybZ2QzbeiXQRjeocyg== X-Received: by 2002:a05:7300:a987:b0:2f2:8857:1804 with SMTP id 5a478bee46e88-2f54b35fffdmr13205599eec.9.1778549013145; Mon, 11 May 2026 18:23:33 -0700 (PDT) Received: from natalia-pc ([191.205.196.185]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f88847506fsm19484481eec.18.2026.05.11.18.23.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 18:23:32 -0700 (PDT) From: =?UTF-8?q?Nat=C3=A1lia=20Salvino=20Andr=C3=A9?= To: andy@kernel.org, dlechner@baylibre.com, jic23@kernel.org, jikos@kernel.org, nuno.sa@analog.com, srinivas.pandruvada@linux.intel.com Cc: =?UTF-8?q?Nat=C3=A1lia=20Salvino=20Andr=C3=A9?= , Pietro Di Consolo Gregorio , linux-iio@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH v3 3/6] iio: light: HID: hid-sensor-als: Refactor channel initialization Date: Mon, 11 May 2026 22:16:19 -0300 Message-ID: <20260512012302.20883-4-natalia.andre@ime.usp.br> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260512012302.20883-1-natalia.andre@ime.usp.br> References: <20260512012302.20883-1-natalia.andre@ime.usp.br> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replace the local als_adjust_channel_bit_mask() function with a compound literal for scan_type initialization to improve code readability. Signed-off-by: Natália Salvino André Co-developed-by: Pietro Di Consolo Gregorio Signed-off-by: Pietro Di Consolo Gregorio --- drivers/iio/light/hid-sensor-als.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/iio/light/hid-sensor-als.c b/drivers/iio/light/hid-sensor-als.c index 384572844162..d72e260b8266 100644 --- a/drivers/iio/light/hid-sensor-als.c +++ b/drivers/iio/light/hid-sensor-als.c @@ -3,6 +3,7 @@ * HID Sensors Driver * Copyright (c) 2012, Intel Corporation. */ +#include #include #include #include @@ -117,17 +118,6 @@ static const struct iio_chan_spec als_channels[] = { IIO_CHAN_SOFT_TIMESTAMP(CHANNEL_SCAN_INDEX_TIMESTAMP) }; -/* Adjust channel real bits based on report descriptor */ -static void als_adjust_channel_bit_mask(struct iio_chan_spec *channels, - int channel, int size) -{ - channels[channel].scan_type.sign = 's'; - /* Real storage bits will change based on the report desc. */ - channels[channel].scan_type.realbits = size * 8; - /* Maximum size of a sample to capture is u32 */ - channels[channel].scan_type.storagebits = sizeof(u32) * 8; -} - /* Channel read_raw handler */ static int als_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, @@ -335,7 +325,11 @@ static int als_parse_report(struct platform_device *pdev, channels[index] = als_channels[i]; st->als_scan_mask[0] |= BIT(i); - als_adjust_channel_bit_mask(channels, index, st->als[i].size); + channels[index].scan_type = (struct iio_scan_type) { + .format = 's', + .realbits = BYTES_TO_BITS(st->als[i].size), + .storagebits = BITS_PER_TYPE(u32), + }; ++index; dev_dbg(&pdev->dev, "als %x:%x\n", st->als[i].index, -- 2.51.0