From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 0/8] iio: magnetometer: ak8975: driver cleanup
Date: Tue, 12 May 2026 15:55:41 +0100 [thread overview]
Message-ID: <20260512155541.1da40c49@jic23-huawei> (raw)
In-Reply-To: <CALoEA-y-bLur7tBnj61hXSnOdbJkco3zyAH8v_-y8+VFfVyEgw@mail.gmail.com>
On Tue, 12 May 2026 11:16:17 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> On Tue, 12 May 2026 at 11:12, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Mon, May 11, 2026 at 01:26:09PM +0200, Joshua Crofts via B4 Relay wrote:
> > > This series is a continuation of the previous ak8975 driver cleanup
> > > effort, as most of the patches were picked.
> > >
> > > Changes include:
> > > - using BIT() and GENMASK() macros
> > > - moving to devm_* resource management
> > > - adding a scan index enum
> > > - moving from using wait loops to iopoll functions
> > > - various code style changes
> >
> > Thanks for doing this!
> >
> > Jonathan, the same Q I had in previous version round, can we get some patches
> > applied to reduce the burden of the series? (I think of 1, 2, 7, 8 and might be
> > more.) As for the series, I think if this version is still not good enough
> > (patch 3) we need to rearrange it so that patch is going to the end (as much as
> > possible) of the series, so we want delay the 'good' ones to be applied.
>
> IMO all patches excluding the shared resource management patch are good
> to go. I can send a new version reordered to reduce the headache.
>
I'll see what picks up easily then you can reorder the rest.
Sashiko indeed not happy with patch 3 and the issues around runtime pm.
Jonathan
prev parent reply other threads:[~2026-05-12 14:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 11:26 [PATCH v7 0/8] iio: magnetometer: ak8975: driver cleanup Joshua Crofts via B4 Relay
2026-05-11 11:26 ` [PATCH v7 1/8] iio: magnetometer: ak8975: modernize polling loops with iopoll() macros Joshua Crofts via B4 Relay
2026-05-12 14:53 ` Jonathan Cameron
2026-05-11 11:26 ` [PATCH v7 2/8] iio: magnetometer: ak8975: check if gpiod read was successful Joshua Crofts via B4 Relay
2026-05-12 14:54 ` Jonathan Cameron
2026-05-11 11:26 ` [PATCH v7 3/8] iio: magnetometer: ak8975: switch to using managed resources Joshua Crofts via B4 Relay
2026-05-11 11:26 ` [PATCH v7 4/8] iio: magnetometer: ak8975: consistently use 'data' parameter Joshua Crofts via B4 Relay
2026-05-12 14:56 ` Jonathan Cameron
2026-05-12 15:03 ` Jonathan Cameron
2026-05-12 15:13 ` Joshua Crofts
2026-05-11 11:26 ` [PATCH v7 5/8] iio: magnetometer: ak8975: unify messages with help of dev_err_probe() Joshua Crofts via B4 Relay
2026-05-12 15:04 ` Jonathan Cameron
2026-05-12 15:08 ` Joshua Crofts
2026-05-11 11:26 ` [PATCH v7 6/8] iio: magnetometer: ak8975: use temporary variable for struct device Joshua Crofts via B4 Relay
2026-05-11 11:26 ` [PATCH v7 7/8] iio: magnetometer: ak8975: add scan mask index enum Joshua Crofts via B4 Relay
2026-05-11 11:26 ` [PATCH v7 8/8] iio: magnetometer: ak8975: make use of the macros from bits.h Joshua Crofts via B4 Relay
2026-05-12 9:12 ` [PATCH v7 0/8] iio: magnetometer: ak8975: driver cleanup Andy Shevchenko
2026-05-12 9:16 ` Joshua Crofts
2026-05-12 14:44 ` Andy Shevchenko
2026-05-12 14:55 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512155541.1da40c49@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox