From: Salah Triki <salah.triki@gmail.com>
To: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Salah Triki <salah.triki@gmail.com>
Subject: [PATCH v7] iio: humidity: ens210: Extend I2C functionality check
Date: Thu, 14 May 2026 09:41:54 +0100 [thread overview]
Message-ID: <20260514084154.298154-1-salah.triki@gmail.com> (raw)
The ENS210 driver requires several specific SMBus protocols to operate:
- WRITE_BYTE for sending commands.
- BYTE_DATA and WORD_DATA for register access.
- I2C_BLOCK_DATA for reading humidity/temperature results.
Update the probe function to explicitly check for these required
functionalities using standard macros. This ensures the driver only
binds to adapters that support the necessary transaction types.
Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
Changes since v6:
- Replaced the incorrect use of I2C_FUNC_SMBUS_EMUL with an explicit
list of required SMBus functionalities as requested by Jonathan Cameron.
- Used combined macros (BYTE_DATA, WORD_DATA) to simplify the check.
Changes since v5:
- Changed patch title from "Fix missing I2C functionality checks" to
"Simplify I2C functionality check" to reflect the new approach.
- Dropped the Fixes tag as the change is now considered hardening rather
than a bug fix.
- Replaced individual functionality checks with a single check for
I2C_FUNC_SMBUS_EMUL as suggested by Jonathan Cameron.
Changes since v4:
- Fixed the alignment and indentation of the I2C functionality check
per Andy's review.
Changes since v3:
- Fixed the alignment and indentation of the I2C functionality check
per Andy's review.
Changes since v2:
- Fixed the alignment and indentation of the I2C functionality check
per Maxime's review.
Changes since v1:
- Updated the I2C functionality test to check for both required native
operations and SMBus emulation (`I2C_FUNC_SMBUS_EMUL`)
drivers/iio/humidity/ens210.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/iio/humidity/ens210.c b/drivers/iio/humidity/ens210.c
index 77418d97f30d..d209f30d61ed 100644
--- a/drivers/iio/humidity/ens210.c
+++ b/drivers/iio/humidity/ens210.c
@@ -204,6 +204,8 @@ static int ens210_probe(struct i2c_client *client)
if (!i2c_check_functionality(client->adapter,
I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
I2C_FUNC_SMBUS_WRITE_BYTE |
+ I2C_FUNC_SMBUS_BYTE_DATA |
+ I2C_FUNC_SMBUS_WORD_DATA |
I2C_FUNC_SMBUS_READ_I2C_BLOCK)) {
return dev_err_probe(&client->dev, -EOPNOTSUPP,
"adapter does not support some i2c transactions\n");
--
2.43.0
reply other threads:[~2026-05-14 8:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514084154.298154-1-salah.triki@gmail.com \
--to=salah.triki@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox