From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
To: jic23@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
sanjayembeddedse@gmail.com, tglx@kernel.org,
christophe.jaillet@wanadoo.fr, mingo@kernel.org, kees@kernel.org,
nabijaczleweli@nabijaczleweli.xyz, kyungmin.park@samsung.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v8 04/12] iio: ssp_sensors: factor out MCU enable/disable helpers
Date: Fri, 15 May 2026 23:10:09 +0530 [thread overview]
Message-ID: <20260515174017.3962168-5-sanjayembedded@gmail.com> (raw)
In-Reply-To: <20260515174017.3962168-1-sanjayembedded@gmail.com>
From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Refactor the MCU enable and disable logic into small helper functions.
This simplifies the control flow and improves readability.
No functional change intended.
Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
---
Changes in v8:
- Following comment from Jonathan, split function to have separate
changes for each small helper function and demote the log level
- v7 change: https://lore.kernel.org/all/20260426091710.3722035-5-sanjayembedded@gmail.com/
---
drivers/iio/common/ssp_sensors/ssp_dev.c | 43 +++++++++++++-----------
1 file changed, 24 insertions(+), 19 deletions(-)
diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
index 51730dae5871..4280eb590c03 100644
--- a/drivers/iio/common/ssp_sensors/ssp_dev.c
+++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
@@ -89,23 +89,28 @@ static void ssp_sync_available_sensors(struct ssp_data *data)
"SSP_MSG2SSP_AP_MCU_SET_DUMPMODE failed\n");
}
-static void ssp_enable_mcu(struct ssp_data *data, bool enable)
+static void ssp_enable_mcu(struct ssp_data *data)
{
- dev_info(&data->spi->dev, "current shutdown = %d, old = %d\n", enable,
- data->shut_down);
-
- if (enable && data->shut_down) {
- data->shut_down = false;
- enable_irq(data->spi->irq);
- enable_irq_wake(data->spi->irq);
- } else if (!enable && !data->shut_down) {
- data->shut_down = true;
- disable_irq(data->spi->irq);
- disable_irq_wake(data->spi->irq);
- } else {
- dev_warn(&data->spi->dev, "current shutdown = %d, old = %d\n",
- enable, data->shut_down);
- }
+ dev_dbg(&data->spi->dev, "enabling MCU (was shutdown: %d)\n", data->shut_down);
+
+ if (!data->shut_down)
+ return;
+
+ data->shut_down = false;
+ enable_irq(data->spi->irq);
+ enable_irq_wake(data->spi->irq);
+}
+
+static void ssp_disable_mcu(struct ssp_data *data)
+{
+ dev_dbg(&data->spi->dev, "disabling MCU (was shutdown: %d)\n", data->shut_down);
+
+ if (data->shut_down)
+ return;
+
+ data->shut_down = true;
+ disable_irq(data->spi->irq);
+ disable_irq_wake(data->spi->irq);
}
/*
@@ -146,10 +151,10 @@ static int ssp_check_fwbl(struct ssp_data *data)
static void ssp_reset_mcu(struct ssp_data *data)
{
- ssp_enable_mcu(data, false);
+ ssp_disable_mcu(data);
ssp_clean_pending_list(data);
ssp_toggle_mcu_reset_gpio(data);
- ssp_enable_mcu(data, true);
+ ssp_enable_mcu(data);
}
static void ssp_wdt_work_func(struct work_struct *work)
@@ -584,7 +589,7 @@ static void ssp_remove(struct spi_device *spi)
dev_err(&data->spi->dev,
"SSP_MSG2SSP_AP_STATUS_SHUTDOWN failed\n");
- ssp_enable_mcu(data, false);
+ ssp_disable_mcu(data);
ssp_disable_wdt_timer(data);
ssp_clean_pending_list(data);
--
2.34.1
next prev parent reply other threads:[~2026-05-15 17:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 17:40 [PATCH v8 00/12] iio: ssp_sensors: driver fixes, refactor and cleanup Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 01/12] iio: ssp_sensors: cancel delayed work_refresh on remove Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 02/12] iio: ssp_sensors: factor out pending list add/remove helpers Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 03/12] iio: ssp_sensors: refactor transfer logic into helper Sanjay Chitroda
2026-05-15 17:40 ` Sanjay Chitroda [this message]
2026-05-15 17:40 ` [PATCH v8 05/12] iio: ssp_sensors: use local struct device Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 06/12] iio: ssp_sensors: fix variable type and declaration order in probe() Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 07/12] iio: ssp_sensors: Drop duplicated wdt timer and work cleanup Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 08/12] iio: ssp_sensors: convert probe and teardown to devm-managed resources Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 09/12] iio: ssp_sensors: use guard() to release mutexes Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 10/12] iio: ssp_sensors: Use dev_err_probe() Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 11/12] iio: ssp_sensors: return errors directly from ssp_irq_msg() Sanjay Chitroda
2026-05-15 17:40 ` [PATCH v8 12/12] iio: ssp_sensors: reuse embedded RX buffer for SPI transfers Sanjay Chitroda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515174017.3962168-5-sanjayembedded@gmail.com \
--to=sanjayembeddedse@gmail.com \
--cc=andy@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kees@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=nuno.sa@analog.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox