From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0567F37DAD7; Fri, 15 May 2026 19:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778871606; cv=none; b=o/TWaVsVjNzA9T/JPK2WU3wt2mQ/I+jZKpxTOIcXzSqxVGpBbu6YYR73Y2UqRdVhhZ+v6qvMYVZw+Fe3oU6wPw47/ti7gWSufc1ISbNhG+U672q+kP+AzP0ADe5buNcLIXqGODmhMP4siudMbnwWPekxKLw98OIfQSsxuLgtcYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778871606; c=relaxed/simple; bh=uoOw1fEfymbsBl96G2s/lqTMA1cP1P2Jc7bAjsYjRT0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FwK9nci7MQaVm//Fl5Sx3ki0RvCp4E+BeYVmMoP1+us4hZGBM62tEPpiyg5UTOtqJXI/B/1tGWL5hVBrwZZfdDDplm+hexIy+lEUOlA/Xr7Ca4FbtY0DNzJXNqO7jOBev/BK+2s2UEeN2yzXzuzlplJgdoIoIjcoOiy6iGst4aU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y/3bG04d; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y/3bG04d" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A52EC2BCB0; Fri, 15 May 2026 18:59:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778871605; bh=uoOw1fEfymbsBl96G2s/lqTMA1cP1P2Jc7bAjsYjRT0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Y/3bG04dizxBnLYBcnQJFTADNXIs1EiHrg6IcPkcZHhT75GXJx7HkVFEA5gI/kycg RFe9P/+FIXPZi+ecJBvrSbLKdObdXYsG66yQbxF6ZL9c9on5KcO3jNOHlavW9uZz/L /Vs/+cht6KWAErBxo9szrGeDNRtcGqW+wW1CZwgu+mUzXkkt8Oo5n72Te7bWWSoewk mspeTg/E5+zhME20JMEpEE8NdMdvIYZT9ekGuirHKT3luJd0ZWPhFla/ARVT9mzeFC J7aUwWm3A1gJ9CWdW2TcpF9nov7t/oQLVXeTjdEKmzNWQfNX1nnFLDuiLeVK3hXiKM bxF7wFO/01zIQ== Date: Fri, 15 May 2026 19:59:54 +0100 From: Jonathan Cameron To: Chris Morgan Cc: linux-iio@vger.kernel.org, andy@kernel.org, nuno.sa@analog.com, dlechner@baylibre.com, jean-baptiste.maneyrol@tdk.com, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, heiko@sntech.de, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, andriy.shevchenko@intel.com, Chris Morgan Subject: Re: [PATCH V7 05/11] iio: imu: inv_icm42607: Add PM support for icm42607 Message-ID: <20260515195954.0cafbaa7@jic23-huawei> In-Reply-To: <20260515130018.237378-6-macroalpha82@gmail.com> References: <20260515130018.237378-1-macroalpha82@gmail.com> <20260515130018.237378-6-macroalpha82@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 15 May 2026 08:00:10 -0500 Chris Morgan wrote: > From: Chris Morgan > > Add power management support for the ICM42607 device driver. > > Signed-off-by: Chris Morgan Sashiko had a comment but I'd ignore it as it's about the rather complex magic that lets us do various forms of PM configs without lots of __maybe_unused etc and it works so don't touch it :) I'm too lazy to check what the dependency ordering is other than pm_ptr() is true in cases where pm_sleep_ptr() whereas the opposite is not true and that means the actual dead code removal occurs at a different point in the code those macros are producing. Anyhow a few really minor things inline. Otherwise LGTM > --- > drivers/iio/imu/inv_icm42607/inv_icm42607.h | 12 ++ > .../iio/imu/inv_icm42607/inv_icm42607_core.c | 143 ++++++++++++++++++ > .../iio/imu/inv_icm42607/inv_icm42607_i2c.c | 1 + > .../iio/imu/inv_icm42607/inv_icm42607_spi.c | 1 + > 4 files changed, 157 insertions(+) > > diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607.h b/drivers/iio/imu/inv_icm42607/inv_icm42607.h > index 2c20e95b237a..5f37999e39a5 100644 > --- a/drivers/iio/imu/inv_icm42607/inv_icm42607.h > +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607.h > diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c > index 1088c5c7076f..e27ad0319a12 100644 > --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c > +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c > static int inv_icm42607_set_conf(struct inv_icm42607_state *st, > const struct inv_icm42607_conf *conf) > { > @@ -198,11 +255,15 @@ static int inv_icm42607_enable_vddio_reg(struct inv_icm42607_state *st) > { > int ret; > > + if (st->vddio_en) > + return 0; > + > ret = regulator_enable(st->vddio_supply); > if (ret) > return ret; > > fsleep(INV_ICM42607_POWER_UP_TIME_US); > + st->vddio_en = 1; It's a bool (which is good) so = true > > return 0; > } > @@ -211,7 +272,10 @@ static void inv_icm42607_disable_vddio_reg(void *_data) > { > struct inv_icm42607_state *st = _data; > > + if (!st->vddio_en) > + return; > regulator_disable(st->vddio_supply); > + st->vddio_en = 0; = false > } > > +static int inv_icm42607_suspend(struct device *dev) > +{ > + struct inv_icm42607_state *st = dev_get_drvdata(dev); > + int ret; > + > + guard(mutex)(&st->lock); > + > + if (pm_runtime_suspended(dev)) > + return 0; > + > + ret = inv_icm42607_set_pwr_mgmt0(st, INV_ICM42607_SENSOR_MODE_OFF, > + INV_ICM42607_SENSOR_MODE_OFF, > + false, NULL); > + if (ret) > + return ret; Trivial but blank line here > + inv_icm42607_disable_vddio_reg(st); > + > + return 0; > +} > + > +static int inv_icm42607_runtime_suspend(struct device *dev) > +{ > + struct inv_icm42607_state *st = dev_get_drvdata(dev); > + int ret = 0; Assigned in all paths I think? If that stops being true I'd probably still introduce the assignment when it becomes the case even though it's a little more code churn. > + > + guard(mutex)(&st->lock); > + > + ret = inv_icm42607_set_pwr_mgmt0(st, INV_ICM42607_SENSOR_MODE_OFF, > + INV_ICM42607_SENSOR_MODE_OFF, false, > + NULL); > + if (ret) > + return ret; > + > + inv_icm42607_disable_vddio_reg(st); > + > + return 0; > +}