From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C5608287E;
	Sat, 16 May 2026 16:46:11 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1778949972; cv=none; b=EPGClYFwBdi0Ep8AkEUkCU2pVaHrP9mBhHdkARH0l3CIdNtpa67TY8tyL0GElrADBLnS53nYoGC+i++qrXlqd/55cy3CRZcLGueOzjDogaONab+mXLOm/W/r+LNZkonV27eTB8FVGcYtIhv0Rk8bp2HVJaEcIfV9pTnQbBO01hU=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1778949972; c=relaxed/simple;
	bh=epSplkKPvSmzfstIC5iCFKRrIgCZ0GQTgJAgTIZTjho=;
	h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=aMhawWwkJnAqh92lM21iZqYzlug7k/BZ6cf/0Cbfyx/qyQlhRIkOK391EGg6Taguy68AduJWJ2FMnnpD2D0ZXQ1iqY8DLJCfPB7e6JzgDtH6WW/JyEJRv+LuXHPZtgW2vGF8EDxZ0ZmjtlWhV6sBTU+Xkk4SVQWpjYkYNfvgYhY=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y2ypxmRY; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y2ypxmRY"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3855C19425;
	Sat, 16 May 2026 16:46:06 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1778949971;
	bh=epSplkKPvSmzfstIC5iCFKRrIgCZ0GQTgJAgTIZTjho=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=Y2ypxmRYK0cMlhArBxQgZTztn9WSSFmfdIMua73CrWOH4z//RK8wZx9OgZa9oIm4V
	 HfJtAqPoRl/oITwZvabzLCbLXKAr1OwsINbt612/IApxrHXB4XUA/1NgxWmxB/x8aN
	 Q7VJMCwSlT2YwPXZS/907OJsIf0BKrb7P5U0EAjFcfZrkR49CD2TZe9s8jbFM4iqxr
	 2tJ0p+Vc7xuiW9k8Es8I8FBI7+RIyQkt3WcSNkNudcVuwBcYlyRp1Ai+I9/+z2t9US
	 JeYT/P0HZc9Zz9x648Ikm2cDdDrR3tO7vJ5UZH5SoDMbaOoQH63d0AqPq7waxNKqld
	 1cF5kjvr9tLZA==
Date: Sat, 16 May 2026 17:46:00 +0100
From: Jonathan Cameron <jic23@kernel.org>
To: Liviu Stan <liviu.stan@analog.com>
Cc: David Lechner <dlechner@baylibre.com>, Nuno =?UTF-8?B?U8Oh?=
 <nuno.sa@analog.com>, Andy Shevchenko <andy@kernel.org>, Michael Hennerich
 <Michael.Hennerich@analog.com>, Rob Herring <robh@kernel.org>, "Krzysztof
 Kozlowski" <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
 "Antoniu Miclaus" <antoniu.miclaus@analog.com>, Francesco Lavra
 <flavra@baylibre.com>, <linux-iio@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>, <linux@analog.com>,
 <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/7] iio: temperature: ltc2983: Use local device
 pointer consistently
Message-ID: <20260516174600.65a65782@jic23-huawei>
In-Reply-To: <20260514144712.64374-3-liviu.stan@analog.com>
References: <20260514144712.64374-1-liviu.stan@analog.com>
	<20260514144712.64374-3-liviu.stan@analog.com>
X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu)
Precedence: bulk
X-Mailing-List: linux-iio@vger.kernel.org
List-Id: <linux-iio.vger.kernel.org>
List-Subscribe: <mailto:linux-iio+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-iio+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 14 May 2026 17:46:49 +0300
Liviu Stan <liviu.stan@analog.com> wrote:

> Some functions define a local 'dev' pointer but still use bare
> '&st->spi->dev' in some code paths, and some don't have it at all.
> Replace all bare references with the local pointer for consistency.
> 
> Fixes: f110f3188e5639c81c457b2b831d40dfe3891bdb ("iio: temperature: Add support for LTC2983")
> Signed-off-by: Liviu Stan <liviu.stan@analog.com>
> ---
> Changes in v2:
> - New patch.
> 
>  drivers/iio/temperature/ltc2983.c | 81 ++++++++++++++++++-------------
>  1 file changed, 46 insertions(+), 35 deletions(-)
> 
> diff --git a/drivers/iio/temperature/ltc2983.c b/drivers/iio/temperature/ltc2983.c
> index a292274e6ff0..e74ea4f87ec9 100644
> --- a/drivers/iio/temperature/ltc2983.c
> +++ b/drivers/iio/temperature/ltc2983.c
> @@ -351,6 +351,7 @@ static int __ltc2983_chan_assign_common(struct ltc2983_data *st,
>  					const struct ltc2983_sensor *sensor,
>  					u32 chan_val)
>  {
> +	struct device *dev = &st->spi->dev;

Why would you do that if no users in the function?  Bring it in when it is
useful only. Note sashiko also spotted this..

Seems that you missed a dev_dbg() call that should have used it just after this.
(that I didn't know but sashiko called it out ;)


Again, a patch by patch build would almost certainly have thrown a warning on this.