From: Jonathan Cameron <jic23@kernel.org>
To: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
sakari.ailus@linux.intel.com,
christoph.muellner@theobroma-systems.com, martink@posteo.de,
mfuzzey@parkeon.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 02/10] iio: accel: mma8452: switch to non-devm request_threaded_irq()
Date: Mon, 18 May 2026 14:31:22 +0100 [thread overview]
Message-ID: <20260518143122.10797b5c@jic23-huawei> (raw)
In-Reply-To: <20260506184749.5b69d86f@jic23-huawei>
On Wed, 6 May 2026 18:47:49 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> On Tue, 5 May 2026 23:16:32 +0530
> Sanjay Chitroda <sanjayembeddedse@gmail.com> wrote:
>
> > From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
> >
> > Avoid using devm_request_threaded_irq() as the driver requires explicit
> > error-handling path(s). Using devm_* API together with goto-based
> > unwinding breaks the expected LIFO resource release model.
> >
> > Add explicit IRQ cleanup in the driver teardown paths to follow kernel
> > resource management conventions.
> >
> > Fixes: 28e3427824cc ("iio: mma8452: Basic support for transient events.")
> For a fixes tag we need to have an explicit issue rather than
> it not following best practice. Patch itself is correct, and if all
> else is good and you don't have a specific ordering problem in mind
> I'll just drop the fixes tag whilst applying.
Applied to testing with the fixes tag dropped.
Thanks,
J
next prev parent reply other threads:[~2026-05-18 13:31 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 17:46 [PATCH v3 00/10] iio: accel: mma8452: improve coding style, pm and resource cleanup Sanjay Chitroda
2026-05-05 17:46 ` [PATCH v3 01/10] iio: accel: mma8452: handle I2C read error(s) in mma8452_read() Sanjay Chitroda
2026-05-18 13:30 ` Jonathan Cameron
2026-05-05 17:46 ` [PATCH v3 02/10] iio: accel: mma8452: switch to non-devm request_threaded_irq() Sanjay Chitroda
2026-05-06 17:47 ` Jonathan Cameron
2026-05-18 13:31 ` Jonathan Cameron [this message]
2026-05-05 17:46 ` [PATCH v3 03/10] iio: accel: mma8452: cleanup codestyle warning Sanjay Chitroda
2026-05-06 9:24 ` Joshua Crofts
2026-05-06 17:53 ` Jonathan Cameron
2026-05-07 7:19 ` Joshua Crofts
2026-05-18 13:32 ` Jonathan Cameron
2026-05-05 17:46 ` [PATCH v3 04/10] iio: accel: mma8452: sort headers alphabetically Sanjay Chitroda
2026-05-06 9:29 ` Joshua Crofts
2026-05-18 13:33 ` Jonathan Cameron
2026-05-05 17:46 ` [PATCH v3 05/10] iio: accel: mma8452: Use dev_err_probe() Sanjay Chitroda
2026-05-05 18:45 ` Joshua Crofts
2026-05-06 9:22 ` Andy Shevchenko
2026-05-06 9:27 ` Joshua Crofts
2026-05-06 9:37 ` Andy Shevchenko
2026-05-18 13:35 ` Jonathan Cameron
2026-05-05 17:46 ` [PATCH v3 06/10] iio: accel: mma8452: convert to bulk regulator usage Sanjay Chitroda
2026-05-05 22:34 ` Joshua Crofts
2026-05-18 13:37 ` Jonathan Cameron
2026-05-06 9:31 ` Andy Shevchenko
2026-05-05 17:46 ` [PATCH v3 07/10] iio: accel: mma8452: use local struct device Sanjay Chitroda
2026-05-06 9:19 ` Joshua Crofts
2026-05-07 2:17 ` Sanjay Chitroda
2026-05-06 9:34 ` Andy Shevchenko
2026-05-05 17:46 ` [PATCH v3 08/10] iio: accel: mma8452: use pm_ptr() and direct runtime PM calls Sanjay Chitroda
2026-05-06 9:42 ` Andy Shevchenko
2026-05-06 18:06 ` Jonathan Cameron
2026-05-07 2:46 ` Sanjay Chitroda
2026-05-07 17:05 ` Jonathan Cameron
2026-05-05 17:46 ` [PATCH v3 09/10] iio: accel: mma8452: Use IIO cleanup helpers Sanjay Chitroda
2026-05-05 17:46 ` [PATCH v3 10/10] iio: accel: mma8452: use guard() to release mutexes Sanjay Chitroda
2026-05-06 9:46 ` Andy Shevchenko
2026-05-06 9:24 ` [PATCH v3 00/10] iio: accel: mma8452: improve coding style, pm and resource cleanup Andy Shevchenko
2026-05-07 2:12 ` Sanjay Chitroda
2026-05-17 20:09 ` Sanjay Chitroda
2026-05-18 7:20 ` Andy Shevchenko
2026-05-18 13:39 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518143122.10797b5c@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=christoph.muellner@theobroma-systems.com \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
--cc=mfuzzey@parkeon.com \
--cc=nuno.sa@analog.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sanjayembeddedse@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox