Linux IIO development
 help / color / mirror / Atom feed
From: Piyush Patle <piyushpatle228@gmail.com>
To: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: jic23@kernel.org, ak@it-klinger.de, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, andy@kernel.org,
	nuno.sa@analog.com, dlechner@baylibre.com
Subject: [PATCH v10 08/11] iio: adc: hx711: split variable assignments in hx711_read and hx711_reset
Date: Mon, 25 May 2026 16:21:24 +0530	[thread overview]
Message-ID: <20260525105127.180156-9-piyushpatle228@gmail.com> (raw)
In-Reply-To: <20260525105127.180156-1-piyushpatle228@gmail.com>

Separate the initial value assignments from the declarations in
hx711_read() and hx711_reset().

This is a small preparatory cleanup before the later loop-iterator and
variant-specific changes adjust the local variable layout in these
functions.

No functional change.

Signed-off-by: Piyush Patle <piyushpatle228@gmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
---
 drivers/iio/adc/hx711.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/hx711.c b/drivers/iio/adc/hx711.c
index 30e1ce321747..4ccb0bf2d71f 100644
--- a/drivers/iio/adc/hx711.c
+++ b/drivers/iio/adc/hx711.c
@@ -159,9 +159,10 @@ static int hx711_read(struct hx711_data *hx711_data, int trailing_pulses)
 {
 	int i, ret;
 	int value = 0;
-	int val = gpiod_get_value(hx711_data->gpiod_dout);
+	int val;
 
 	/* we double check if it's really down */
+	val = gpiod_get_value(hx711_data->gpiod_dout);
 	if (val)
 		return -EIO;
 
@@ -204,8 +205,9 @@ static int hx711_wait_for_ready(struct hx711_data *hx711_data)
 
 static int hx711_reset(struct hx711_data *hx711_data)
 {
-	int val = hx711_wait_for_ready(hx711_data);
+	int val;
 
+	val = hx711_wait_for_ready(hx711_data);
 	if (val) {
 		/*
 		 * an examination with the oszilloscope indicated
-- 
2.43.0


  parent reply	other threads:[~2026-05-25 10:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25 10:51 [PATCH v10 00/11] iio: adc: Add support for AVIA HX710B ADC Piyush Patle
2026-05-25 10:51 ` [PATCH v10 01/11] dt-bindings: iio: adc: hx711: clean up existing binding text Piyush Patle
2026-05-25 10:51 ` [PATCH v10 02/11] dt-bindings: iio: adc: hx711: add VSUP supply property Piyush Patle
2026-05-27 17:34   ` Jonathan Cameron
2026-05-25 10:51 ` [PATCH v10 03/11] dt-bindings: iio: adc: hx711: add RATE GPIO property Piyush Patle
2026-05-25 10:51 ` [PATCH v10 04/11] dt-bindings: iio: adc: hx711: add HX710B support Piyush Patle
2026-05-27 17:37   ` Jonathan Cameron
     [not found]   ` <20260525111144.CA7E71F000E9@smtp.kernel.org>
     [not found]     ` <20260525-clanking-possum-4ba58b466854@spud>
2026-05-27 17:41       ` Jonathan Cameron
2026-05-28  8:54         ` Conor Dooley
2026-05-28 13:08           ` Jonathan Cameron
2026-05-28 14:09             ` Conor Dooley
2026-05-25 10:51 ` [PATCH v10 05/11] iio: adc: hx711: move scale computation to per-device storage Piyush Patle
2026-05-25 10:51 ` [PATCH v10 06/11] iio: adc: hx711: introduce hx711_chip_info structure Piyush Patle
2026-05-25 10:51 ` [PATCH v10 07/11] iio: adc: hx711: pass trailing pulse count into hx711_read Piyush Patle
2026-05-25 10:51 ` Piyush Patle [this message]
2026-05-25 10:51 ` [PATCH v10 09/11] iio: adc: hx711: localize loop iterators in hx711_read Piyush Patle
2026-05-25 10:51 ` [PATCH v10 10/11] iio: adc: hx711: pass iio_chan_spec to hx711_reset_read Piyush Patle
2026-05-25 10:51 ` [PATCH v10 11/11] iio: adc: hx711: add support for HX710B Piyush Patle
2026-05-27 17:54   ` Jonathan Cameron
2026-05-27 17:32 ` [PATCH v10 00/11] iio: adc: Add support for AVIA HX710B ADC Jonathan Cameron
2026-05-27 17:45 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260525105127.180156-9-piyushpatle228@gmail.com \
    --to=piyushpatle228@gmail.com \
    --cc=ak@it-klinger.de \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox