From: Jad Keskes <inasj268@gmail.com>
To: linux-staging@lists.linux.dev
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Jad Keskes <inasj268@gmail.com>
Subject: [PATCH] staging: iio: impedance-analyzer: fix CamelCase in ad5933
Date: Tue, 2 Jun 2026 21:14:28 +0100 [thread overview]
Message-ID: <20260602201428.213890-1-inasj268@gmail.com> (raw)
checkpatch flagged mixed-case suffixes in #define names: _mVpp and _Hz.
Rename to _MV_PP and _HZ to follow kernel UPPER_SNAKE_CASE convention.
Signed-off-by: Jad Keskes <inasj268@gmail.com>
---
drivers/staging/iio/impedance-analyzer/ad5933.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
index 85a422329..62ed5e40e 100644
--- a/drivers/staging/iio/impedance-analyzer/ad5933.c
+++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
@@ -43,10 +43,10 @@
#define AD5933_CTRL_POWER_DOWN (0xA << 4)
#define AD5933_CTRL_STANDBY (0xB << 4)
-#define AD5933_CTRL_RANGE_2000mVpp (0x0 << 1)
-#define AD5933_CTRL_RANGE_200mVpp (0x1 << 1)
-#define AD5933_CTRL_RANGE_400mVpp (0x2 << 1)
-#define AD5933_CTRL_RANGE_1000mVpp (0x3 << 1)
+#define AD5933_CTRL_RANGE_2000_MV_PP (0x0 << 1)
+#define AD5933_CTRL_RANGE_200_MV_PP (0x1 << 1)
+#define AD5933_CTRL_RANGE_400_MV_PP (0x2 << 1)
+#define AD5933_CTRL_RANGE_1000_MV_PP (0x3 << 1)
#define AD5933_CTRL_RANGE(x) ((x) << 1)
#define AD5933_CTRL_PGA_GAIN_1 (0x1 << 0)
@@ -68,8 +68,8 @@
#define AD5933_I2C_ADDR_POINTER 0xB0
/* Device Specs */
-#define AD5933_INT_OSC_FREQ_Hz 16776000
-#define AD5933_MAX_OUTPUT_FREQ_Hz 100000
+#define AD5933_INT_OSC_FREQ_HZ 16776000
+#define AD5933_MAX_OUTPUT_FREQ_HZ 100000
#define AD5933_MAX_RETRIES 100
#define AD5933_OUT_RANGE 1
@@ -303,7 +303,7 @@ static ssize_t ad5933_store_frequency(struct device *dev,
if (ret)
return ret;
- if (val > AD5933_MAX_OUTPUT_FREQ_Hz)
+ if (val > AD5933_MAX_OUTPUT_FREQ_HZ)
return -EINVAL;
if (!iio_device_claim_direct(indio_dev))
@@ -699,7 +699,7 @@ static int ad5933_probe(struct i2c_client *client)
st->mclk_hz = ext_clk_hz;
st->ctrl_lb = AD5933_CTRL_EXT_SYSCLK;
} else {
- st->mclk_hz = AD5933_INT_OSC_FREQ_Hz;
+ st->mclk_hz = AD5933_INT_OSC_FREQ_HZ;
st->ctrl_lb = AD5933_CTRL_INT_SYSCLK;
}
--
2.54.0
next reply other threads:[~2026-06-02 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 20:14 Jad Keskes [this message]
2026-06-03 6:33 ` [PATCH] staging: iio: impedance-analyzer: fix CamelCase in ad5933 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260602201428.213890-1-inasj268@gmail.com \
--to=inasj268@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox