Re: [PATCH] iio: adc: ad7380: select REGMAP

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 02 Jun 2026 17:28:35 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:

> On Tue, 2026-06-02 at 15:39 +0000, Sam Moelius wrote:
> > From: Samuel Moelius <samuel.moelius@trailofbits.com>
> > 
> > The AD7380 driver uses generic regmap types and APIs. However, its Kconfig entry
> > does not select REGMAP.
> > 
> > As a result, AD7380 can be enabled from an allnoconfig-derived config with
> > SPI_MASTER=y while REGMAP remains unset, causing ad7380.o to fail to build.
> > 
> > Fixes: b095217c104b ("iio: adc: ad7380: new driver for AD7380 ADCs")
> > 
> > Signed-off-by: Samuel Moelius <samuel.moelius@trailofbits.com>
> > ---  
> 
> Change looks good but it seems the commit message will fail checkpatch. With that:
> 
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> 
> >  drivers/iio/adc/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> > index a9dedbb8eb46..c79341848698 100644
> > --- a/drivers/iio/adc/Kconfig
> > +++ b/drivers/iio/adc/Kconfig
> > @@ -311,6 +311,7 @@ config AD7298
> >  config AD7380
> >  	tristate "Analog Devices AD7380 ADC driver"
> >  	depends on SPI_MASTER
> > +	select REGMAP

Would REGMAP_SPI be the better choice?  I assume either works from
build point of view, but nicer to select all the support this actually needs.

> >  	select SPI_OFFLOAD
> >  	select IIO_BUFFER
> >  	select IIO_BUFFER_DMAENGINE