From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Miao Li <limiao870622@163.com>,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
dixitparmar19@gmail.com, waqar.hameed@axis.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
limiao@kylinos.cn
Subject: Re: [PATCH] iio: accel: stk8312: Update includes to match IWYU
Date: Wed, 3 Jun 2026 11:56:04 +0100 [thread overview]
Message-ID: <20260603115604.0bb2592a@jic23-huawei> (raw)
In-Reply-To: <ah_BVAIR40VIquaY@ashevche-desk.local>
On Wed, 3 Jun 2026 08:53:24 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Wed, Jun 03, 2026 at 09:47:54AM +0800, Miao Li wrote:
>
> > Update the list of included headers in stk8312.c using
> > Include-What-You-Use (IWYU) tool, mainly to remove kernel.h
> > and add missing headers such as array_size.h, bits.h,
> > dev_printk.h, etc.
>
> Same comments as per your other patch.
>
Main take away here is if you are sending a new type of change,
test the waters (and get initial feedback) on that change applied
to a single driver. That way you don't waste your time or that
of reviewers on common problems.
Thanks,
Jonathan
prev parent reply other threads:[~2026-06-03 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 1:47 [PATCH] iio: accel: stk8312: Update includes to match IWYU Miao Li
2026-06-03 5:53 ` Andy Shevchenko
2026-06-03 10:56 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260603115604.0bb2592a@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dixitparmar19@gmail.com \
--cc=dlechner@baylibre.com \
--cc=limiao870622@163.com \
--cc=limiao@kylinos.cn \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox