Re: [PATCH v2] iio: adc: ad7380: select REGMAP

[Jonathan Cameron <jic23@kernel.org>]

On Wed, 3 Jun 2026 07:53:09 -0400
Samuel Moelius <sam.moelius@trailofbits.com> wrote:

> On Wed, Jun 3, 2026 at 7:01 AM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > On Wed, 3 Jun 2026 04:14:54 +0300
> > Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> >  
> > > On Tue, Jun 02, 2026 at 04:45:39PM +0000, Sam Moelius wrote:
> > >  
> > > > The AD7380 driver uses generic regmap types and APIs. However, its
> > > > Kconfig entry does not select REGMAP.
> > > >
> > > > As a result, AD7380 can be enabled from an allnoconfig-derived config
> > > > with SPI_MASTER=y while REGMAP remains unset, causing ad7380.o to fail
> > > > to build.  
> > >
> > > Okay,
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> > >  
> > I replied late to v1.  Unless I'm missing something makes more sense
> > to select REGMAP_SPI  
> 
> REGMAP_SPI also builds drivers/base/regmap/regmap-spi.o, which AD7380
> does not use.
> 
> So, to merely fix the ad7380.o build failure, REGMAP seems to be the
> right choice.

Good point.  I failed to notice it uses a custom regmap.

Applied to the fixes-togreg branch of iio.git and marked for stable.

Given timing I may well drag that into the queue for the merge window
rather than ending a separate pull request for fixes.