Re: [PATCH v2] iio: dac: mcp47feb02: refactor MCP47FEB02 I2C driver into two modules

[Jonathan Cameron <jic23@kernel.org>]

On Wed, 3 Jun 2026 14:52:41 +0000
<Ariana.Lazar@microchip.com> wrote:

> Hi Jonathan,
> 
> Thank you for the review.
> 
> 
> > I don't mind reviewing this on it's own but won't merge it until
> > we have a reason (i.e. that SPI part)
> >   
> 
> In the first version of this patch series the SPI file was included
> too, but it was recommended not to for better clarity:
> https://lore.kernel.org/all/20260419171658.2dbb9884@jic23-huawei/
> 
> My understanding was to submit a driver refactoring (splitting the
> driver into core and I2C modules) and submit later another patch to add
> the SPI part (the SPI module and modified dt binding). Please tell me
> if this is alright or I should do it differently.
> 

Ah. I didn't explain that clearly sorry.

Same series, different patches.  So this is the first patch and
should result in no funcational changes (looks good)
I've kind of lost track but there may be some precursor cleanup /
improvements to make in additional patches before that one splitting
core and I2C apart.

The patch after this then adds the new device support over the SPI
bus.

Jonathan


> 
> > 
> > 
> > All of these belong in separate patches from the fundamental code
> > move. Probably before it given they seem like a good idea anyway..
> >   
> 
> After mcp47feb02 I2C driver was accepted in upstream I've submitted a
> new patch series for mcp48feb02 SPI driver. Changes I did among the
> refactor were from the review for that driver:
> https://lore.kernel.org/all/aY3m5V05FOH5sut6@smile.fi.intel.com/
> 
> I will remove the reference mismatch part, which is a fix for
> mcp47feb02, and I will submit it in v3 for the series:
> https://lore.kernel.org/all/20260414-mcp47feb02-fix4-v1-1-9d71badfd25e@microchip.com/
> in order to add the fixes from later reviews (even if those patches
> will not be continued).
> 
> Best regards,
> Ariana