From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 251213E16A2 for ; Thu, 4 Jun 2026 20:20:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780604458; cv=none; b=CWKJR/km7WS00Pr790IfR1fEyPd18Ll++p4qASGUDba6dYPHUihc1ZARoOmGgWzqxHiZlttOYTe5FUyrC70vrfc6v+sL9ksyoZzm6FaejCO50a+VuFb9gzu3ag57QQOzPCNMIZXJCc3BPxcXsDfA8/GXL340nQHAXSmMMMT+vqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780604458; c=relaxed/simple; bh=/j0yoBsCu8NGkydoASkp03/pE7NYlqgUbqZAH0h9sPM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aIS2xxfFznb+PRmhukgTC3WNUYZf+yE8PBk2dbnOzz7iMmjSZNoyCPsQR1V0dHTVmwE3lFVksG4klLvpycjN3e/ZTaGCedz17NvjBww1maMqaVvggwCaJH9YFj7LvVGDAg29QTW1LXbPMrNnxS1o7WdKE/duHzimKl9HsW+XlyY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h8f0nMuU; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h8f0nMuU" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-7e6ec655c80so647135a34.0 for ; Thu, 04 Jun 2026 13:20:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780604456; x=1781209256; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uoMqdu8RRCBkFFI6bXhhcIjEsTWvXd186vi0OB+91hY=; b=h8f0nMuULGMsN+e8VGvwGe1aIOqCV64WtFbbl7Qi9nKYKDdof5tvvv3qu94Aa08kU6 1mvBRSovD3FAPyf02zuCrwJp9hvDGONuiilR9r2r8UB4Gm4iOV5wNN+71G17kZyMNmyc 8D6LvrgBr+PWjARF/AmiDVpryPU/CtCRlfw9U6zjli2O93Cy8+qnpx9T3KkpaCZuB/5T YCipsfPpJSlf7Wxv70ui/UD1VxYMprC1Z6UrM7bISMJB5XtKsTnw2ezfBcrLPjtOzAkc y5XLzULCUXd/6P9blQ8AKJXhH4cxOL054u0x1LBAbTEi1mU17gTK5TgL+HMye0O0eJrE uNVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780604456; x=1781209256; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uoMqdu8RRCBkFFI6bXhhcIjEsTWvXd186vi0OB+91hY=; b=mcc1k+aiK5l74EQpBsF9ZvQQiqYJELidB720I8C8auEsFIP0DaCdvN0D2s9n2pq3pv +ehNpFPoFLbGuVcUHovfgBRmFzm5Ph2BD7WP0AeLRWsNuyy36PIIJcsMmpnmFSCQomSB Xs9AcLukudq9Y8TCpk2uSj88aWSL5NL/TwW23RApkkMNwnMbwCUGvHkCnomuubT4Qkjv Gq6T3Q5a3L8u82zkCWMJSAJDYXr7aL8v1qE3eA9U8h49iz7WR1d1TYF5xAqhlTm4bNL3 PUGZjrk1MQw8AeJjJ0VwiMfyC3Qoq55Uje+PCorRVvZg+hMZYM6IRKwuvCcT/RbFG4/J mAaA== X-Gm-Message-State: AOJu0Yxv+qEBJp9SxaxJj1kvhztF62L84ftT6R2JXEMGfgLIodObxKBi SxGDKHTVOUMplVYSyOCcztOfRd/hKT285EIBMlKGok/5hkyFnMvEnQDSmbPjkmmy X-Gm-Gg: Acq92OE2PwgAJeUIDHEMKhi+FJy2d2/XJoIVahyXM1C85oNRi9J1WZpvMQ+i56x401b Wm8g8m28smiHpTCs/EJtsmeUe/3jplDczxoBqMVum4nc2dofkV2v7TWD7S3r5PYNhe2tlfmmVoY i3+H043a3gglx0uVbqhsz+Cq8zZ7gDUltmdf15hjPDT9pNwFbZw/x/gKXI/oNdjllbpzI5LwJbK pYGREOIMDlniBvJI8aZIypgPSNvSXei2U6rjyAiNp6FiqsjFxh/zwuHl+o+ycy/A+OQ8MsgtPuP inPuppzumM+4Bbuzt09kJh1JUZtwSuwRaNrBO7rwR54ux8FN+c2bD+Bqp5x923sIevCgnEdT6Ee PX0KtSiIbszGrb8BBG+qcZmCvTEomhAKIJ4yx+eM+zDMRmVuqriYWwc6c1IJDmNuh/PwgQi74OG x2VZx3kzuUqWcXe64bfm2y81V56bkiR1c= X-Received: by 2002:a05:6830:6d28:b0:7e3:d7d6:a4b7 with SMTP id 46e09a7af769-7e70c6884e7mr176167a34.3.1780604456197; Thu, 04 Jun 2026 13:20:56 -0700 (PDT) Received: from localhost.localdomain ([2600:1700:fb0:1bc0::54]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e6e796c675sm4541800a34.24.2026.06.04.13.20.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 13:20:55 -0700 (PDT) From: Chris Morgan To: linux-iio@vger.kernel.org Cc: andy@kernel.org, nuno.sa@analog.com, dlechner@baylibre.com, jic23@kernel.org, jean-baptiste.maneyrol@tdk.com, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, heiko@sntech.de, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, andriy.shevchenko@intel.com, Chris Morgan Subject: [PATCH V10 5/9] iio: imu: inv_icm42607: Add PM support for icm42607 Date: Thu, 4 Jun 2026 15:18:27 -0500 Message-ID: <20260604201832.60656-6-macroalpha82@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260604201832.60656-1-macroalpha82@gmail.com> References: <20260604201832.60656-1-macroalpha82@gmail.com> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chris Morgan Add power management support for the ICM42607 device driver. Signed-off-by: Chris Morgan --- drivers/iio/imu/inv_icm42607/inv_icm42607.h | 18 +++ .../iio/imu/inv_icm42607/inv_icm42607_core.c | 123 ++++++++++++++++++ .../iio/imu/inv_icm42607/inv_icm42607_i2c.c | 1 + .../iio/imu/inv_icm42607/inv_icm42607_spi.c | 1 + 4 files changed, 143 insertions(+) diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607.h b/drivers/iio/imu/inv_icm42607/inv_icm42607.h index 7928f81300ed8..72327381b6dbc 100644 --- a/drivers/iio/imu/inv_icm42607/inv_icm42607.h +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607.h @@ -10,6 +10,7 @@ #include #include #include +#include #include #include @@ -103,22 +104,32 @@ struct inv_icm42607_hw { const struct inv_icm42607_conf *conf; }; +struct inv_icm42607_suspended { + enum inv_icm42607_sensor_mode gyro; + enum inv_icm42607_sensor_mode accel; + bool temp; +}; + /** * struct inv_icm42607_state - driver state variables * @lock: lock for serializing multiple registers access. * @hw: Hardware specific data. * @map: regmap pointer. * @vddio_supply: I/O voltage regulator for the chip. + * @vddio_en: I/O voltage status for runtime PM. * @orientation: sensor chip orientation relative to main hardware. * @conf: chip sensors configurations. + * @suspended: suspended sensors configuration. */ struct inv_icm42607_state { struct mutex lock; const struct inv_icm42607_hw *hw; struct regmap *map; struct regulator *vddio_supply; + bool vddio_en; struct iio_mount_matrix orientation; struct inv_icm42607_conf conf; + struct inv_icm42607_suspended suspended; }; /* Virtual register addresses: @bank on MSB (4 upper bits), @address on LSB */ @@ -337,11 +348,18 @@ struct inv_icm42607_state { #define INV_ICM42607_GYRO_STARTUP_TIME_MS 30 #define INV_ICM42607_TEMP_STARTUP_TIME_MS 77 +/* + * Suspend delay assumed from other icm42600 series device, not + * documented in datasheet. + */ +#define INV_ICM42607_SUSPEND_DELAY_MS 2000 + typedef int (*inv_icm42607_bus_setup)(struct inv_icm42607_state *); extern const struct regmap_config inv_icm42607_regmap_config; extern const struct inv_icm42607_hw inv_icm42607_hw_data; extern const struct inv_icm42607_hw inv_icm42607p_hw_data; +extern const struct dev_pm_ops inv_icm42607_pm_ops; int inv_icm42607_core_probe(struct regmap *regmap, const struct inv_icm42607_hw *hw, diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c index 4448d63e95fd7..39620da92bd43 100644 --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include @@ -72,6 +73,51 @@ const struct inv_icm42607_hw inv_icm42607p_hw_data = { }; EXPORT_SYMBOL_NS_GPL(inv_icm42607p_hw_data, "IIO_ICM42607"); +static int inv_icm42607_set_pwr_mgmt0(struct inv_icm42607_state *st, + enum inv_icm42607_sensor_mode gyro, + enum inv_icm42607_sensor_mode accel, + bool temp, unsigned int *sleep_ms) +{ + enum inv_icm42607_sensor_mode oldgyro = st->conf.gyro.mode; + enum inv_icm42607_sensor_mode oldaccel = st->conf.accel.mode; + bool oldtemp = st->conf.temp_en; + unsigned int sleepval; + unsigned int val; + int ret; + + if (gyro == oldgyro && accel == oldaccel && temp == oldtemp) + return 0; + + val = FIELD_PREP(INV_ICM42607_PWR_MGMT0_GYRO_MODE_MASK, gyro); + val |= FIELD_PREP(INV_ICM42607_PWR_MGMT0_ACCEL_MODE_MASK, accel); + if (!temp) + val |= INV_ICM42607_PWR_MGMT0_ACCEL_LP_CLK_SEL; + ret = regmap_write(st->map, INV_ICM42607_REG_PWR_MGMT0, val); + if (ret) + return ret; + + st->conf.gyro.mode = gyro; + st->conf.accel.mode = accel; + st->conf.temp_en = temp; + + sleepval = 0; + if (temp && !oldtemp) + sleepval = max(sleepval, INV_ICM42607_TEMP_STARTUP_TIME_MS); + + if (accel != oldaccel) + sleepval = max(sleepval, INV_ICM42607_ACCEL_STARTUP_TIME_MS); + + if (gyro != oldgyro) + sleepval = max(sleepval, INV_ICM42607_GYRO_STARTUP_TIME_MS); + + if (sleep_ms) + *sleep_ms = sleepval; + else if (sleepval) + fsleep(sleepval * 1000); + + return 0; +} + static int inv_icm42607_set_conf(struct inv_icm42607_state *st, const struct inv_icm42607_conf *conf) { @@ -184,12 +230,17 @@ static int inv_icm42607_enable_vddio_reg(struct inv_icm42607_state *st) { int ret; + if (st->vddio_en) + return 0; + ret = regulator_enable(st->vddio_supply); if (ret) return ret; fsleep(INV_ICM42607_POWER_UP_TIME_US); + st->vddio_en = true; + return 0; } @@ -197,7 +248,12 @@ static void inv_icm42607_disable_vddio_reg(void *_data) { struct inv_icm42607_state *st = _data; + if (!st->vddio_en) + return; + regulator_disable(st->vddio_supply); + + st->vddio_en = false; } int inv_icm42607_core_probe(struct regmap *regmap, @@ -247,10 +303,77 @@ int inv_icm42607_core_probe(struct regmap *regmap, if (ret) return ret; + ret = devm_pm_runtime_set_active_enabled(dev); + if (ret) + return ret; + + pm_runtime_set_autosuspend_delay(dev, INV_ICM42607_SUSPEND_DELAY_MS); + pm_runtime_use_autosuspend(dev); + return 0; } EXPORT_SYMBOL_NS_GPL(inv_icm42607_core_probe, "IIO_ICM42607"); +static int inv_icm42607_suspend(struct device *dev) +{ + struct inv_icm42607_state *st = dev_get_drvdata(dev); + int ret; + + ret = pm_runtime_force_suspend(dev); + if (ret) + return ret; + + inv_icm42607_disable_vddio_reg(st); + + return 0; +} + +static int inv_icm42607_resume(struct device *dev) +{ + struct inv_icm42607_state *st = dev_get_drvdata(dev); + int ret; + + ret = inv_icm42607_enable_vddio_reg(st); + if (ret) + return ret; + + return pm_runtime_force_resume(dev); +} + +static int inv_icm42607_runtime_suspend(struct device *dev) +{ + struct inv_icm42607_state *st = dev_get_drvdata(dev); + + guard(mutex)(&st->lock); + + /* save sensors state */ + st->suspended.gyro = st->conf.gyro.mode; + st->suspended.accel = st->conf.accel.mode; + st->suspended.temp = st->conf.temp_en; + + return inv_icm42607_set_pwr_mgmt0(st, INV_ICM42607_SENSOR_MODE_OFF, + INV_ICM42607_SENSOR_MODE_OFF, false, + NULL); +} + +static int inv_icm42607_runtime_resume(struct device *dev) +{ + struct inv_icm42607_state *st = dev_get_drvdata(dev); + + guard(mutex)(&st->lock); + + /* restore sensors state */ + return inv_icm42607_set_pwr_mgmt0(st, st->suspended.gyro, + st->suspended.accel, + st->suspended.temp, NULL); +} + +EXPORT_NS_GPL_DEV_PM_OPS(inv_icm42607_pm_ops, IIO_ICM42607) = { + SYSTEM_SLEEP_PM_OPS(inv_icm42607_suspend, inv_icm42607_resume) + RUNTIME_PM_OPS(inv_icm42607_runtime_suspend, + inv_icm42607_runtime_resume, NULL) +}; + MODULE_AUTHOR("InvenSense, Inc."); MODULE_DESCRIPTION("InvenSense ICM-42607x device driver"); MODULE_LICENSE("GPL"); diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_i2c.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_i2c.c index 22ac51108cd3b..cd08bb9514f2d 100644 --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_i2c.c +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_i2c.c @@ -82,6 +82,7 @@ static struct i2c_driver inv_icm42607_driver = { .driver = { .name = "inv-icm42607-i2c", .of_match_table = inv_icm42607_of_matches, + .pm = pm_ptr(&inv_icm42607_pm_ops), }, .id_table = inv_icm42607_id, .probe = inv_icm42607_probe, diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_spi.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_spi.c index 421d3ec1cded3..8a82e1610531b 100644 --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_spi.c +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_spi.c @@ -94,6 +94,7 @@ static struct spi_driver inv_icm42607_driver = { .driver = { .name = "inv-icm42607-spi", .of_match_table = inv_icm42607_of_matches, + .pm = pm_ptr(&inv_icm42607_pm_ops), }, .id_table = inv_icm42607_spi_id_table, .probe = inv_icm42607_probe, -- 2.43.0