From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Hungyu Lin <dennylin0707@gmail.com>,
jagathjog1996@gmail.com, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: imu: bmi323: remove unnecessary cast in watermark limit
Date: Wed, 10 Jun 2026 16:36:43 +0100 [thread overview]
Message-ID: <20260610163643.42dfc1eb@jic23-huawei> (raw)
In-Reply-To: <aigU_yoAQxKb6POn@ashevche-desk.local>
On Tue, 9 Jun 2026 16:28:31 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Mon, Jun 08, 2026 at 12:15:58PM +0000, Hungyu Lin wrote:
> > Remove the explicit u32 cast in the watermark limit calculation.
> >
> > The BMI323_FIFO_FULL_IN_FRAMES macro can be used directly with
> > min() without triggering type issues.
>
> Right, now it looks much better.
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
Agreed. Easy to check these min conditions as there is good documentation in
minmax.h Entry that is relevant here I think is this one.
* - Unsigned arguments can be compared against non-negative signed constants.
Applied to the testing branch of iio.git.
Thanks,
Jonathan
prev parent reply other threads:[~2026-06-10 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 12:15 [PATCH v2] iio: imu: bmi323: remove unnecessary cast in watermark limit Hungyu Lin
2026-06-08 20:20 ` Nuno Sá
2026-06-09 13:28 ` Andy Shevchenko
2026-06-10 15:36 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610163643.42dfc1eb@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dennylin0707@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jagathjog1996@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox