From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Hungyu Lin" <dennylin0707@gmail.com>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: pressure: bm1390: replace short msleeps with fsleep
Date: Wed, 10 Jun 2026 16:37:49 +0100 [thread overview]
Message-ID: <20260610163749.5d2cd98f@jic23-huawei> (raw)
In-Reply-To: <aievYfVvpJGCfTEz@ashevche-desk.local>
On Tue, 9 Jun 2026 09:14:57 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Tue, Jun 09, 2026 at 12:57:10AM +0000, Hungyu Lin wrote:
> > Replace msleep(1) with fsleep(1000) for the driver's short
> > delays.
> >
> > The BM1390 datasheet specifies a 1 ms reset cancel wait time
> > (tSC1) during the power-on sequence. Use fsleep() for these
> > short delays because it automatically selects the most
> > appropriate sleep mechanism and provides standardized timing
> > slack.
>
> Same comment as per v1.
>
> ...
>
> > - msleep(1);
> > + fsleep(1000);
>
> And in case you really still want to do this, use multipliers
>
> fsleep(1 * USEC_PER_MSEC);
>
> (but this might require time.h to be included).
>
We seem to have a consensus that this is really just adding noise
in this particular case, so let us drop this one.
Thanks,
Jonathan
prev parent reply other threads:[~2026-06-10 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 0:57 [PATCH v2] iio: pressure: bm1390: replace short msleeps with fsleep Hungyu Lin
2026-06-09 6:14 ` Andy Shevchenko
2026-06-10 15:37 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610163749.5d2cd98f@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dennylin0707@gmail.com \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox