From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: "Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>, "Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Puranjay Mohan" <puranjay@kernel.org>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Ramona Gradinariu" <ramona.gradinariu@analog.com>,
"Esteban Blanc" <eblanc@baylibre.com>,
"Sergiu Cuciurean" <sergiu.cuciurean@analog.com>,
"Dragos Bogdan" <dragos.bogdan@analog.com>,
"Alisa-Dariana Roman" <alisa.roman@analog.com>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Renato Lui Geh" <renatogeh@gmail.com>,
"Ramona Bolboaca" <ramona.bolboaca@analog.com>,
"Kim Seer Paller" <kimseer.paller@analog.com>,
"Marilene Andrade Garcia" <marilene.agarcia@gmail.com>,
"Marius Cristea" <marius.cristea@microchip.com>,
"Marcus Folkesson" <marcus.folkesson@gmail.com>,
"Kent Gustavsson" <kent@minoris.se>,
"Kurt Borja" <kuurtb@gmail.com>,
"Leonard Göhrs" <l.goehrs@pengutronix.de>,
kernel@pengutronix.de,
"Rodrigo Alencar" <rodrigo.alencar@analog.com>,
"Gustavo Silva" <gustavograzs@gmail.com>,
"Alexis Czezar Torreno" <alexisczezar.torreno@analog.com>,
"Janani Sunil" <janani.sunil@analog.com>,
"Anshul Dalal" <anshulusr@gmail.com>,
"Ricardo Ribalda" <ribalda@kernel.org>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Alex Lanzano" <lanzano.alex@gmail.com>,
"Jagath Jog J" <jagathjog1996@gmail.com>,
"Jean-Baptiste Maneyrol" <jean-baptiste.maneyrol@tdk.com>,
"Remi Buisson" <remi.buisson@tdk.com>,
"Herve Codina" <herve.codina@bootlin.com>,
"Petre Rodan" <petre.rodan@subdimension.ro>,
"Andreas Klinger" <ak@it-klinger.de>,
"Harshit Mogalapalli" <harshit.m.mogalapalli@oracle.com>,
"Andrew Ijano" <andrew.ijano@gmail.com>,
"Giorgi Tchankvetadze" <giorgitchankvetadze1997@gmail.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Md Shofiqul Islam" <shofiqtest@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Stepan Ionichev" <sozdayvek@gmail.com>,
"Sam Daly" <sam@samdaly.ie>,
"Dixit Parmar" <dixitparmar19@gmail.com>,
"Colin Ian King" <colin.i.king@gmail.com>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"David Jander" <david@protonic.nl>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Gabriel Rondon" <grondon@gmail.com>,
"David Marinovic" <david.marinovic@pupin.rs>,
"Lukas Schmid" <lukas.schmid@netcube.li>,
"Shi Hao" <i.shihao.999@gmail.com>,
"Rahman Mahmutović" <mahmutovicrahman5@gmail.com>,
linux@analog.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 11/13] iio: Initialize spi_device_id arrays using member names
Date: Wed, 24 Jun 2026 18:52:44 +0100 [thread overview]
Message-ID: <20260624185244.140b8368@jic23-huawei> (raw)
In-Reply-To: <CAD++jLkRbaPMichpGGQnX5yasRHmY05=95qaOAvH9buHgTKa4Q@mail.gmail.com>
On Fri, 19 Jun 2026 22:19:50 +0200
Linus Walleij <linusw@kernel.org> wrote:
> On Fri, Jun 19, 2026 at 5:55 PM Uwe Kleine-König (The Capable Hub)
> <u.kleine-koenig@baylibre.com> wrote:
>
> > While being less compact, using named initializers allows to more easily
> > see which members of the structs are assigned which value without having
> > to lookup the declaration of the struct. And it's also more robust
> > against changes to the struct definition.
> >
> > The mentioned robustness is relevant for a planned change to struct
> > spi_device_id that replaces .driver_data by an anonymous union.
> >
> > This patch doesn't modify the compiled arrays, only their representation
> > in source form benefits. The former was confirmed with x86 and arm64
> > builds.
> >
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
>
> Acked-by: Linus Walleij <linusw@kernel.org>
>
> Yours,
> Linus Walleij
Applied. Thanks!
J
next prev parent reply other threads:[~2026-06-24 17:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 15:54 [PATCH v1 00/13] iio: Use named initializers for device_id structures Uwe Kleine-König (The Capable Hub)
2026-06-19 15:54 ` [PATCH v1 01/13] iio: Initialize i2c_device_id arrays using member names (part 2) Uwe Kleine-König (The Capable Hub)
2026-06-24 17:34 ` Jonathan Cameron
2026-06-19 15:54 ` [PATCH v1 02/13] iio: adc: ti-tsc2046: Simplify device abstraction Uwe Kleine-König (The Capable Hub)
2026-06-19 15:54 ` [PATCH v1 03/13] iio: adc: ti-tsc2046: Drop unused member from private data Uwe Kleine-König (The Capable Hub)
2026-06-22 10:30 ` Andy Shevchenko
2026-06-22 13:32 ` Uwe Kleine-König (The Capable Hub)
2026-06-19 15:54 ` [PATCH v1 04/13] iio: adc: max1241: Simplify device abstraction Uwe Kleine-König (The Capable Hub)
2026-06-24 17:37 ` Jonathan Cameron
2026-06-19 15:54 ` [PATCH v1 05/13] iio: dac: max5522: " Uwe Kleine-König (The Capable Hub)
2026-06-24 17:38 ` Jonathan Cameron
2026-06-19 15:54 ` [PATCH v1 06/13] iio: frequency: ad9523: Simplify driver a bit Uwe Kleine-König (The Capable Hub)
2026-06-24 17:43 ` Jonathan Cameron
2026-06-19 15:54 ` [PATCH v1 07/13] iio: imu: adis16550: Simplify device abstraction Uwe Kleine-König (The Capable Hub)
2026-06-24 17:47 ` Jonathan Cameron
2026-06-19 15:54 ` [PATCH v1 08/13] iio: magnetometer: hmc5843: " Uwe Kleine-König (The Capable Hub)
2026-06-24 17:48 ` Jonathan Cameron
2026-06-19 15:54 ` [PATCH v1 09/13] iio: accel: bmc150: Explicitly set spi .driver_data Uwe Kleine-König (The Capable Hub)
2026-06-24 17:50 ` Jonathan Cameron
2026-06-19 15:54 ` [PATCH v1 10/13] iio: Drop unused assignment of spi_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-06-19 15:54 ` [PATCH v1 11/13] iio: Initialize spi_device_id arrays using member names Uwe Kleine-König (The Capable Hub)
2026-06-19 20:19 ` Linus Walleij
2026-06-24 17:52 ` Jonathan Cameron [this message]
2026-06-19 15:54 ` [PATCH v1 12/13] staging: iio: Drop unused assignment of spi_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-06-19 15:54 ` [PATCH v1 13/13] staging: iio: Initialize spi_device_id arrays using member names Uwe Kleine-König (The Capable Hub)
2026-06-24 17:54 ` Jonathan Cameron
2026-06-26 13:18 ` Uwe Kleine-König (The Capable Hub)
2026-06-22 11:43 ` [PATCH v1 00/13] iio: Use named initializers for device_id structures Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260624185244.140b8368@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=ak@it-klinger.de \
--cc=alexisczezar.torreno@analog.com \
--cc=alisa.roman@analog.com \
--cc=andrew.ijano@gmail.com \
--cc=andy@kernel.org \
--cc=anshulusr@gmail.com \
--cc=antoniu.miclaus@analog.com \
--cc=bigeasy@linutronix.de \
--cc=brgl@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=david.marinovic@pupin.rs \
--cc=david@protonic.nl \
--cc=dixitparmar19@gmail.com \
--cc=dlechner@baylibre.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dragos.bogdan@analog.com \
--cc=eblanc@baylibre.com \
--cc=giorgitchankvetadze1997@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=grondon@gmail.com \
--cc=gustavograzs@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=herve.codina@bootlin.com \
--cc=i.shihao.999@gmail.com \
--cc=jagathjog1996@gmail.com \
--cc=janani.sunil@analog.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=kent@minoris.se \
--cc=kernel@pengutronix.de \
--cc=kimseer.paller@analog.com \
--cc=krzk@kernel.org \
--cc=kuurtb@gmail.com \
--cc=l.goehrs@pengutronix.de \
--cc=lanzano.alex@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=lorenzo@kernel.org \
--cc=lukas.schmid@netcube.li \
--cc=mahmutovicrahman5@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=marcus.folkesson@gmail.com \
--cc=marilene.agarcia@gmail.com \
--cc=marius.cristea@microchip.com \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=o.rempel@pengutronix.de \
--cc=petre.rodan@subdimension.ro \
--cc=puranjay@kernel.org \
--cc=ramona.bolboaca@analog.com \
--cc=ramona.gradinariu@analog.com \
--cc=remi.buisson@tdk.com \
--cc=renatogeh@gmail.com \
--cc=ribalda@kernel.org \
--cc=rodrigo.alencar@analog.com \
--cc=sam@samdaly.ie \
--cc=sergiu.cuciurean@analog.com \
--cc=shofiqtest@gmail.com \
--cc=sozdayvek@gmail.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox