From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: rodrigo.alencar@analog.com,
Michael Auchter <michael.auchter@ni.com>,
linux@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org,
Michael Hennerich <Michael.Hennerich@analog.com>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Subject: Re: [PATCH v6 1/6] iio: dac: ad5686: refactor command/data macros
Date: Mon, 6 Jul 2026 00:09:05 +0100 [thread overview]
Message-ID: <20260706000905.7448dc01@jic23-huawei> (raw)
In-Reply-To: <akppC9oRzspyq8du@ashevche-desk.local>
On Sun, 5 Jul 2026 17:24:11 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Sun, Jul 05, 2026 at 12:38:56PM +0100, Rodrigo Alencar via B4 Relay wrote:
>
> > Replace usage of bit shifting macros for FIELD_PREP(), which would not
> > ignore bit masking when preparing SPI/I2C commands.
>
> It's not marked as a fix and has no explanation why.
>
Agreed - this needs to stand on its own as a description, without needing
to know this is both hardening code and closing down real issues with debugfs
(IIRC from the sashiko reports that lead to this).
Maybe sensible to add both a tag for sashiko suggesting / reporting it
and a link to that review.
Thanks,
Jonathan
next prev parent reply other threads:[~2026-07-05 23:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-05 11:38 [PATCH v6 0/6] New features for the AD5686 IIO driver Rodrigo Alencar via B4 Relay
2026-07-05 11:38 ` [PATCH v6 1/6] iio: dac: ad5686: refactor command/data macros Rodrigo Alencar via B4 Relay
2026-07-05 14:24 ` Andy Shevchenko
2026-07-05 23:09 ` Jonathan Cameron [this message]
2026-07-05 23:29 ` Jonathan Cameron
2026-07-05 11:38 ` [PATCH v6 2/6] iio: dac: ad5686: introduce sync operation Rodrigo Alencar via B4 Relay
2026-07-05 11:38 ` [PATCH v6 3/6] iio: dac: ad5686: implement new sync() op for the spi bus Rodrigo Alencar via B4 Relay
2026-07-05 11:38 ` [PATCH v6 4/6] iio: dac: ad5686: read_raw/write_raw: use guard(mutex)() Rodrigo Alencar via B4 Relay
2026-07-05 11:39 ` [PATCH v6 5/6] iio: dac: ad5686: add triggered buffer support Rodrigo Alencar via B4 Relay
2026-07-05 11:39 ` [PATCH v6 6/6] iio: dac: ad5686: add gain control support Rodrigo Alencar via B4 Relay
2026-07-05 23:30 ` [PATCH v6 0/6] New features for the AD5686 IIO driver Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706000905.7448dc01@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=michael.auchter@ni.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=rodrigo.alencar@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox